public inbox for iwd@lists.linux.dev
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH v5 4/6] station: Use Affinities property to change roaming threshold
Date: Wed, 28 Aug 2024 12:24:26 -0700	[thread overview]
Message-ID: <20240828192428.902761-4-prestwoj@gmail.com> (raw)
In-Reply-To: <20240828192428.902761-1-prestwoj@gmail.com>

When the affinity is set to the current BSS lower the roaming
threshold to loosly lock IWD to the current BSS. The lower
threshold is automatically removed upon roaming/disconnection
since the affinity array is also cleared out.
---
 src/station.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/src/station.c b/src/station.c
index 1eeefe75..c45d13df 100644
--- a/src/station.c
+++ b/src/station.c
@@ -4580,6 +4580,9 @@ static void station_affinity_disconnected_cb(struct l_dbus *dbus,
 	station->affinity_watch = 0;
 
 	l_debug("client that set affinity has disconnected");
+
+	/* The client who set the affinity disconnected, raise the threshold */
+	netdev_raise_signal_threshold(station->netdev);
 }
 
 static void station_affinity_watch_destroy(void *user_data)
@@ -4612,6 +4615,7 @@ static struct l_dbus_message *station_property_set_affinities(
 	const char *new_path = NULL;
 	struct scan_bss *new_bss = NULL;
 	struct scan_bss *old_bss = NULL;
+	bool lower_threshold = false;
 
 	if (!station->connected_network)
 		return dbus_error_not_connected(message);
@@ -4665,6 +4669,8 @@ static struct l_dbus_message *station_property_set_affinities(
 	if (new_path) {
 		l_queue_push_head(station->affinities, l_strdup(new_path));
 
+		lower_threshold = true;
+
 		if (!station->affinity_watch) {
 			station->affinity_client = l_strdup(sender);
 			station->affinity_watch = l_dbus_add_disconnect_watch(
@@ -4677,6 +4683,17 @@ static struct l_dbus_message *station_property_set_affinities(
 	} else if (station->affinity_watch)
 		l_dbus_remove_watch(dbus, station->affinity_watch);
 
+	/*
+	 * If affinity was set to the current BSS, lower the roam threshold. If
+	 * the connected BSS was not in the list raise the signal threshold.
+	 * The threshold may already be raised, in which case netdev will detect
+	 * this and do nothing.
+	 */
+	if (lower_threshold)
+		netdev_lower_signal_threshold(station->netdev);
+	else
+		netdev_raise_signal_threshold(station->netdev);
+
 	complete(dbus, message, NULL);
 
 	l_dbus_property_changed(dbus, netdev_get_path(station->netdev),
-- 
2.34.1


  parent reply	other threads:[~2024-08-28 19:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-28 19:24 [PATCH v5 1/6] doc: Document station Affinities property James Prestwood
2024-08-28 19:24 ` [PATCH v5 2/6] dbus: add PermissionDenied DBus error James Prestwood
2024-08-28 19:24 ` [PATCH v5 3/6] station: add Affinities DBus property James Prestwood
2024-08-28 19:24 ` James Prestwood [this message]
2024-08-28 19:24 ` [PATCH v5 5/6] auto-t: add affinities property for station, and extended_service_set James Prestwood
2024-08-28 19:24 ` [PATCH v5 6/6] auto-t: add tests for Affinities behavior James Prestwood
2024-09-03 15:25 ` [PATCH v5 1/6] doc: Document station Affinities property Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240828192428.902761-4-prestwoj@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox