Re: [PATCH v2 1/2] scan: don't survey on external scans

Denis Kenzior
2024-09-06T19:01:02Z

Hi James,

On 9/5/24 10:26 AM, James Prestwood wrote:
> Since surveys end up making driver calls in the kernel its not
> entirely known how they are implemented or how long they will
> take. For this reason the survey will be skipped if getting the
> results from an external scan.
>
> Doing this also fixes a crash caused by external scans where the
> scan request pointer is not checked and dereferenced:
>
> 0x00005ffa6a0376de in get_survey_done (user_data=0x5ffa783a3f90) at src/scan.c:2059
> 0x0000749646a29bbd in ?? () from /usr/lib/libell.so.0
> 0x0000749646a243cb in ?? () from /usr/lib/libell.so.0
> 0x0000749646a24655 in l_main_iterate () from /usr/lib/libell.so.0
> 0x0000749646a24ace in l_main_run () from /usr/lib/libell.so.0
> 0x0000749646a263a4 in l_main_run_with_signal () from /usr/lib/libell.so.0
> 0x00005ffa6a00d642 in main (argc=<optimized out>, argv=<optimized out>) at src/main.c:614
>
> Reported-by: Daniel Bond <danielbondno@gmail.com>
> ---
> src/scan.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> v2:
> * Disabled scan surveys rather than allowing a NULL scan request
>

Both applied, thanks.

Regards,
-Denis