From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH] manager: fix UseDefaultInterface warning
Date: Fri, 20 Sep 2024 09:36:14 -0700 [thread overview]
Message-ID: <20240920163614.207001-1-prestwoj@gmail.com> (raw)
This logic was incorrect here, we only want to print if the option
is used, not if its unset.
---
src/manager.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/manager.c b/src/manager.c
index 5bedfcc5..436daa56 100644
--- a/src/manager.c
+++ b/src/manager.c
@@ -894,11 +894,11 @@ static int manager_init(void)
}
if (!l_settings_get_bool(config, "General",
- "UseDefaultInterface", &use_default)) {
+ "UseDefaultInterface", &use_default))
+ use_default = false;
+ else
l_warn("[General].UseDefaultInterface is deprecated, please "
"use [DriverQuirks].DefaultInterface instead");
- use_default = false;
- }
return 0;
--
2.34.1
next reply other threads:[~2024-09-20 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 16:36 James Prestwood [this message]
2024-09-25 14:53 ` [PATCH] manager: fix UseDefaultInterface warning Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240920163614.207001-1-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox