* [PATCH] manager: fix UseDefaultInterface warning
@ 2024-09-20 16:36 James Prestwood
2024-09-25 14:53 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: James Prestwood @ 2024-09-20 16:36 UTC (permalink / raw)
To: iwd; +Cc: James Prestwood
This logic was incorrect here, we only want to print if the option
is used, not if its unset.
---
src/manager.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/manager.c b/src/manager.c
index 5bedfcc5..436daa56 100644
--- a/src/manager.c
+++ b/src/manager.c
@@ -894,11 +894,11 @@ static int manager_init(void)
}
if (!l_settings_get_bool(config, "General",
- "UseDefaultInterface", &use_default)) {
+ "UseDefaultInterface", &use_default))
+ use_default = false;
+ else
l_warn("[General].UseDefaultInterface is deprecated, please "
"use [DriverQuirks].DefaultInterface instead");
- use_default = false;
- }
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] manager: fix UseDefaultInterface warning
2024-09-20 16:36 [PATCH] manager: fix UseDefaultInterface warning James Prestwood
@ 2024-09-25 14:53 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2024-09-25 14:53 UTC (permalink / raw)
To: James Prestwood, iwd
Hi James,
On 9/20/24 11:36 AM, James Prestwood wrote:
> This logic was incorrect here, we only want to print if the option
> is used, not if its unset.
> ---
> src/manager.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-25 14:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-20 16:36 [PATCH] manager: fix UseDefaultInterface warning James Prestwood
2024-09-25 14:53 ` Denis Kenzior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox