From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH 08/16] dpp-util: check the AKM is "psk" before further parsing the object
Date: Tue, 24 Sep 2024 05:04:39 -0700 [thread overview]
Message-ID: <20240924120447.251761-8-prestwoj@gmail.com> (raw)
In-Reply-To: <20240924120447.251761-1-prestwoj@gmail.com>
---
src/dpp-util.c | 24 +++++++++++++++---------
1 file changed, 15 insertions(+), 9 deletions(-)
diff --git a/src/dpp-util.c b/src/dpp-util.c
index 62db2081..2e4b181b 100644
--- a/src/dpp-util.c
+++ b/src/dpp-util.c
@@ -196,6 +196,7 @@ struct dpp_configuration *dpp_parse_configuration_object(const char *json,
_auto_(l_free) char *akm = NULL;
_auto_(l_free) char *pass = NULL;
_auto_(l_free) char *psk = NULL;
+ uint32_t akm_suites;
c = json_contents_new(json, json_len);
if (!c)
@@ -229,23 +230,28 @@ struct dpp_configuration *dpp_parse_configuration_object(const char *json,
JSON_UNDEFINED))
goto free_contents;
- if (!pass && (!psk || strlen(psk) != 64))
+ akm_suites = dpp_parse_akm(akm);
+
+ if (!akm_suites)
goto free_contents;
config = l_new(struct dpp_configuration, 1);
+ config->akm_suites = akm_suites;
- if (pass)
- config->passphrase = l_steal_ptr(pass);
- else
- config->psk = l_steal_ptr(psk);
+ if (IE_AKM_IS_PSK(akm_suites)) {
+ if (!pass && (!psk || strlen(psk) != 64))
+ goto free_config;
+
+ if (pass)
+ config->passphrase = l_steal_ptr(pass);
+ else
+ config->psk = l_steal_ptr(psk);
+ } else
+ goto free_config;
memcpy(config->ssid, ssid, strlen(ssid));
config->ssid_len = strlen(ssid);
- config->akm_suites = dpp_parse_akm(akm);
- if (!config->akm_suites)
- goto free_config;
-
if (json_iter_is_valid(&extra)) {
if (!dpp_parse_extra_options(config, &extra))
l_warn("Extra settings failed to parse!");
--
2.34.1
next prev parent reply other threads:[~2024-09-24 12:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 12:04 [PATCH 01/16] ie: add IE_AKM_IS_PSK James Prestwood
2024-09-24 12:04 ` [PATCH 02/16] dpp-util: refactor dpp_configuration_new into a _psk helper James Prestwood
2024-09-24 12:04 ` [PATCH 03/16] dpp: fix some return/cleanup issues for error cases James Prestwood
2024-09-24 12:04 ` [PATCH 04/16] dpp-util: refactor dpp_configuration_to_json for only PSK networks James Prestwood
2024-09-24 12:04 ` [PATCH 05/16] dpp: refactor dpp_send_config_response to take JSON as a parameter James Prestwood
2024-09-24 12:04 ` [PATCH 06/16] dpp: refactor dpp_configuration_start to take the " James Prestwood
2024-09-24 12:04 ` [PATCH 07/16] dpp: refactor config writing, add checks for PSK James Prestwood
2024-09-24 12:04 ` James Prestwood [this message]
2024-09-24 12:04 ` [PATCH 09/16] dbus: add generic DPP agent interface James Prestwood
2024-09-24 12:04 ` [PATCH 10/16] dpp: replace PKEX agent with generic DPP agent James Prestwood
2024-09-24 12:04 ` [PATCH 11/16] agent: add APIs for DeviceProvisioningAgent James Prestwood
2024-09-24 12:04 ` [PATCH 12/16] dpp: replace SharedCodeAgent with DeviceProvisioningAgent James Prestwood
2024-09-24 12:04 ` [PATCH 13/16] dpp: remove agent path from StartConfigurator James Prestwood
2024-09-24 12:04 ` [PATCH 14/16] auto-t: update utils to use DeviceProvisioningAgent James Prestwood
2024-09-24 12:04 ` [PATCH 15/16] auto-t: update PKEX test " James Prestwood
2024-09-24 12:04 ` [PATCH 16/16] doc: Document new DeviceProvisioningAgent James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240924120447.251761-8-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox