public inbox for iwd@lists.linux.dev
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH 1/2] wiphy: parse TX/RX frame types, and API to check auth frame support
Date: Fri, 11 Oct 2024 07:55:02 -0700	[thread overview]
Message-ID: <20241011145503.51330-1-prestwoj@gmail.com> (raw)

Drivers have been identified that do not support authentication via
CMD_FRAME. This prevents FT from succeeding but since there is no
way to check this in IWD station cannot handle it gracefully.

Now IWD can parse the TX/RX frame types and check if authentication
is supported and plan the type of roam according to what protocol
will work correctly.
---
 src/wiphy.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 src/wiphy.h |  1 +
 2 files changed, 55 insertions(+)

diff --git a/src/wiphy.c b/src/wiphy.c
index 06f72ef2..cc0e6dd7 100644
--- a/src/wiphy.c
+++ b/src/wiphy.c
@@ -150,6 +150,8 @@ struct wiphy {
 	bool ap_probe_resp_offload : 1;
 	bool supports_uapsd : 1;
 	bool supports_cmd_offchannel : 1;
+	/* Bit 0 for TX, Bit 1 for RX */
+	uint8_t supports_auth_frame : 2;
 };
 
 static struct l_queue *wiphy_list = NULL;
@@ -938,6 +940,11 @@ bool wiphy_supports_cmd_offchannel(const struct wiphy *wiphy)
 	return wiphy->supports_cmd_offchannel;
 }
 
+bool wiphy_supports_auth_frame(const struct wiphy *wiphy)
+{
+	return wiphy->supports_auth_frame == 0x03;
+}
+
 const uint8_t *wiphy_get_ht_capabilities(const struct wiphy *wiphy,
 						enum band_freq band,
 						size_t *size)
@@ -1816,6 +1823,45 @@ static void parse_iftype_extended_capabilities(struct wiphy *wiphy,
 	}
 }
 
+static void wiphy_parse_frame_types(struct wiphy *wiphy,
+					struct l_genl_attr *attr, bool tx)
+{
+	uint16_t type, len;
+	const void *data;
+
+	while (l_genl_attr_next(attr, NULL, NULL, NULL)) {
+		struct l_genl_attr types;
+
+		if (!l_genl_attr_recurse(attr, &types))
+			continue;
+
+		while (l_genl_attr_next(&types, &type, &len, &data)) {
+			uint16_t frame_type;
+
+			if (L_WARN_ON(type != NL80211_ATTR_FRAME_TYPE))
+				continue;
+
+			if (L_WARN_ON(len != 2))
+				continue;
+
+			frame_type = l_get_le16(data);
+
+			switch (frame_type) {
+			/* Authentication */
+			case 0x00b0:
+				if (tx)
+					wiphy->supports_auth_frame |= 0x01;
+				else
+					wiphy->supports_auth_frame |= 0x02;
+				break;
+			default:
+				break;
+			}
+
+		}
+	}
+}
+
 static void wiphy_parse_attributes(struct wiphy *wiphy,
 					struct l_genl_msg *msg)
 {
@@ -1903,6 +1949,14 @@ static void wiphy_parse_attributes(struct wiphy *wiphy,
 		case NL80211_ATTR_SUPPORT_AP_UAPSD:
 			wiphy->supports_uapsd = true;
 			break;
+		case NL80211_ATTR_TX_FRAME_TYPES:
+			if (l_genl_attr_recurse(&attr, &nested))
+				wiphy_parse_frame_types(wiphy, &nested, true);
+			break;
+		case NL80211_ATTR_RX_FRAME_TYPES:
+			if (l_genl_attr_recurse(&attr, &nested))
+				wiphy_parse_frame_types(wiphy, &nested, false);
+			break;
 		}
 	}
 }
diff --git a/src/wiphy.h b/src/wiphy.h
index 17e53075..fe7e9e49 100644
--- a/src/wiphy.h
+++ b/src/wiphy.h
@@ -142,6 +142,7 @@ void wiphy_get_reg_domain_country(struct wiphy *wiphy, char *out);
 bool wiphy_country_is_unknown(struct wiphy *wiphy);
 bool wiphy_supports_uapsd(const struct wiphy *wiphy);
 bool wiphy_supports_cmd_offchannel(const struct wiphy *wiphy);
+bool wiphy_supports_auth_frame(const struct wiphy *wiphy);
 
 const uint8_t *wiphy_get_ht_capabilities(const struct wiphy *wiphy,
 						enum band_freq band,
-- 
2.34.1


             reply	other threads:[~2024-10-11 14:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11 14:55 James Prestwood [this message]
2024-10-11 14:55 ` [PATCH 2/2] station: check if authentication is supported via CMD_FRAME James Prestwood
2024-10-21 17:55 ` [PATCH 1/2] wiphy: parse TX/RX frame types, and API to check auth frame support James Prestwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241011145503.51330-1-prestwoj@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox