Re: [PATCH v2 2/4] network: don't allow connection to OWE AKM if disabled

Denis Kenzior
2024-10-24T14:02:58Z

Hi James,

On 10/23/24 1:29 PM, James Prestwood wrote:
> ---
> src/network.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/network.c b/src/network.c
> index 20d9a3dd..5a856fb4 100644
> --- a/src/network.c
> +++ b/src/network.c
> @@ -911,6 +911,9 @@ int network_can_connect_bss(struct network *network, const struct scan_bss *bss)
> return ret;
> }
>
> + if (IE_AKM_IS_OWE(rsn.akm_suites) && wiphy_owe_disabled(wiphy))
> + return -EPERM;
> +

Hmm, why do we need this if we already check wiphy_owe_disabled in
wiphy_select_akm in patch 1?

...

Ah, I guess this function doesn't perform the special case check like
station_build_handshake_rsn() does. That's probably why we have the problem
with reconnects

> if (!config || !config->have_transition_disable) {
> if (band == BAND_FREQ_6_GHZ)
> goto mfp_no_tkip;

Regards,
-Denis