[PATCH v2] handshake: add more debugging around PMKSA caching

[PATCH v2] handshake: add more debugging around PMKSA caching

[James Prestwood]

Instead of just printing the PMKSA pointer separate this into two
separate debug messages, one for if the PMKSA exists and the other
if it does not. In addition print out the MAC of the AP so we have
a reference of which PMKSA this is.
---
 src/handshake.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/handshake.c b/src/handshake.c
index f73f91d1..bee31beb 100644
--- a/src/handshake.c
+++ b/src/handshake.c
@@ -1272,10 +1272,12 @@ void handshake_state_cache_pmksa(struct handshake_state *s)
 {
 	struct pmksa *pmksa = handshake_state_steal_pmksa(s);
 
-	l_debug("%p", pmksa);
-
-	if (!pmksa)
+	if (!pmksa) {
+		l_debug("No PMKSA for "MAC, MAC_STR(s->aa));
 		return;
+	}
+
+	l_debug("Caching PMKSA for "MAC, MAC_STR(s->aa));
 
 	if (L_WARN_ON(pmksa_cache_put(pmksa) < 0))
 		l_free(pmksa);
-- 
2.34.1

Re: [PATCH v2] handshake: add more debugging around PMKSA caching

[Denis Kenzior]

Hi James,

On 1/6/25 9:34 AM, James Prestwood wrote:
> Instead of just printing the PMKSA pointer separate this into two
> separate debug messages, one for if the PMKSA exists and the other
> if it does not. In addition print out the MAC of the AP so we have
> a reference of which PMKSA this is.
> ---
>   src/handshake.c | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)

Applied, thanks.

Regards,
-Denis