public inbox for iwd@lists.linux.dev
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [RFC] netdev: Don't use external auth with PMKSA
Date: Mon, 27 Jan 2025 08:19:59 -0800	[thread overview]
Message-ID: <20250127161959.37878-1-prestwoj@gmail.com> (raw)

Based on user reports the driver seems to get confused when external
auth is used along with including a PMKID.
---
 src/netdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/netdev.c b/src/netdev.c
index 2a6d94fc..addddff9 100644
--- a/src/netdev.c
+++ b/src/netdev.c
@@ -2499,7 +2499,9 @@ static struct l_genl_msg *netdev_build_cmd_connect(struct netdev *netdev,
 	case CONNECTION_TYPE_SOFTMAC:
 		break;
 	case CONNECTION_TYPE_FULLMAC:
-		l_genl_msg_append_attr(msg,
+		/* If we have a PMKSA for SAE we won't be doing external auth */
+		if (IE_AKM_IS_SAE(hs->akm_suite) && !hs->have_pmksa)
+			l_genl_msg_append_attr(msg,
 				NL80211_ATTR_EXTERNAL_AUTH_SUPPORT, 0, NULL);
 		break;
 	case CONNECTION_TYPE_SAE_OFFLOAD:
-- 
2.34.1


                 reply	other threads:[~2025-01-27 16:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250127161959.37878-1-prestwoj@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox