From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH 3/4] wiphy: clean up some spammy prints
Date: Tue, 11 Feb 2025 11:26:55 -0800 [thread overview]
Message-ID: <20250211192656.83157-3-prestwoj@gmail.com> (raw)
In-Reply-To: <20250211192656.83157-1-prestwoj@gmail.com>
First, wiphy_select_akm is called multiple times for any connection
so we shouldn't be printing in here as its redundant.
Second, the external auth print was in a similar situation but this
would even print when scanning, which really clouds the logs.
---
src/wiphy.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/src/wiphy.c b/src/wiphy.c
index 3d761251..c7df648a 100644
--- a/src/wiphy.c
+++ b/src/wiphy.c
@@ -245,10 +245,6 @@ static bool wiphy_can_connect_sae(struct wiphy *wiphy)
return true;
/* Case 3 */
- iwd_notice(IWD_NOTICE_CONNECT_INFO,
- "FullMAC driver: %s using SAE. Expect EXTERNAL_AUTH",
- wiphy->driver_str);
-
return true;
}
@@ -312,8 +308,6 @@ enum ie_rsn_akm_suite wiphy_select_akm(struct wiphy *wiphy,
* met, we can fallback to WPA2 (if the AKM is present).
*/
if (ie_rsne_is_wpa3_personal(info)) {
- l_debug("Network is WPA3-Personal...");
-
if (!wiphy_can_connect_sae(wiphy)) {
l_debug("Can't use SAE, trying WPA2");
goto wpa2_personal;
--
2.34.1
next prev parent reply other threads:[~2025-02-11 19:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 19:26 [PATCH 1/4] eap: initialize vendor_id/vendor_type to zero James Prestwood
2025-02-11 19:26 ` [PATCH 2/4] netdev: fail the connection if sending external auth fails James Prestwood
2025-02-11 19:26 ` James Prestwood [this message]
2025-02-11 19:26 ` [PATCH 4/4] station: print security of network when connecting James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211192656.83157-3-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox