From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH v2 1/5] netdev: don't set CQM thresholds for fullmac cards
Date: Thu, 13 Feb 2025 12:18:12 -0800 [thread overview]
Message-ID: <20250213201816.230112-2-prestwoj@gmail.com> (raw)
In-Reply-To: <20250213201816.230112-1-prestwoj@gmail.com>
Since roaming is handled by the firmware setting CQM thresholds for
roaming is pointless.
---
src/netdev.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/src/netdev.c b/src/netdev.c
index ecf61823..e0a39851 100644
--- a/src/netdev.c
+++ b/src/netdev.c
@@ -3827,6 +3827,15 @@ static void netdev_cmd_set_cqm_cb(struct l_genl_msg *msg, void *user_data)
static int netdev_cqm_rssi_update(struct netdev *netdev)
{
struct l_genl_msg *msg;
+ struct netdev_handshake_state *nhs = l_container_of(netdev->handshake,
+ struct netdev_handshake_state, super);
+
+ /*
+ * Fullmac cards handle roaming in firmware, there is no need to set
+ * CQM thresholds
+ */
+ if (nhs->type == CONNECTION_TYPE_FULLMAC)
+ return 0;
l_debug("");
--
2.34.1
next prev parent reply other threads:[~2025-02-13 20:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 20:18 [PATCH v2 0/5] PMKSA support for fullmac drivers James Prestwood
2025-02-13 20:18 ` James Prestwood [this message]
2025-02-13 20:18 ` [PATCH v2 2/5] netdev: remove/update some iwd_notice logs James Prestwood
2025-02-13 20:18 ` [PATCH v2 3/5] pmksa: add driver callbacks and pmksa_cache_free James Prestwood
2025-02-13 20:18 ` [PATCH v2 4/5] handshake: use pmksa_cache_free James Prestwood
2025-02-13 20:18 ` [PATCH v2 5/5] netdev: implement PMKSA for fullmac drivers James Prestwood
2025-04-01 16:17 ` [PATCH v2 0/5] PMKSA support " Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213201816.230112-2-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox