From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH 2/9] scan: fix out of bound array access for survey results
Date: Wed, 16 Apr 2025 05:34:07 -0700 [thread overview]
Message-ID: <20250416123414.114231-2-prestwoj@gmail.com> (raw)
In-Reply-To: <20250416123414.114231-1-prestwoj@gmail.com>
The survey arrays were exactly the number of valid channels for a
given band (e.g. 14 for 2.4GHz) but since channels start at 1 this
means that the last channel for a band would overflow the array.
---
src/scan.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/scan.c b/src/scan.c
index aeab6516..dfd667bb 100644
--- a/src/scan.c
+++ b/src/scan.c
@@ -143,9 +143,9 @@ struct scan_survey {
};
struct scan_survey_results {
- struct scan_survey survey_2_4[14];
- struct scan_survey survey_5[196];
- struct scan_survey survey_6[233];
+ struct scan_survey survey_2_4[15];
+ struct scan_survey survey_5[197];
+ struct scan_survey survey_6[234];
};
struct scan_results {
--
2.34.1
next prev parent reply other threads:[~2025-04-16 12:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 12:34 [PATCH 1/9] monitor: fix spelling Exausted -> Exhausted James Prestwood
2025-04-16 12:34 ` James Prestwood [this message]
2025-04-16 17:20 ` [PATCH 2/9] scan: fix out of bound array access for survey results Denis Kenzior
2025-04-16 17:21 ` James Prestwood
2025-04-16 12:34 ` [PATCH 3/9] dpp-util: fail on duplicate values in URI James Prestwood
2025-04-16 12:34 ` [PATCH 4/9] unit: add test for duplicate URI elements James Prestwood
2025-04-16 12:34 ` [PATCH 5/9] monitor: add size check for interworking IE parsing James Prestwood
2025-04-16 12:34 ` [PATCH 6/9] storage: add length check in __storage_decrypt James Prestwood
2025-04-16 12:34 ` [PATCH 7/9] unit: add test-storage James Prestwood
2025-04-16 12:34 ` [PATCH 8/9] station: check return when advancing iterator James Prestwood
2025-04-16 12:34 ` [PATCH 9/9] eap-mschapv2: Fix leak of state->user on error path James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416123414.114231-2-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox