From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH v2 4/9] unit: add test for duplicate URI elements
Date: Wed, 16 Apr 2025 10:33:40 -0700 [thread overview]
Message-ID: <20250416173345.136025-4-prestwoj@gmail.com> (raw)
In-Reply-To: <20250416173345.136025-1-prestwoj@gmail.com>
---
unit/test-dpp.c | 32 ++++++++++++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/unit/test-dpp.c b/unit/test-dpp.c
index 70e79814..af2f5813 100644
--- a/unit/test-dpp.c
+++ b/unit/test-dpp.c
@@ -116,6 +116,29 @@ struct dpp_test_info bad_channels[] = {
},
};
+struct dpp_test_info duplicates[] = {
+ /* Duplicate key */
+ {
+ .uri = "DPP:K:MDkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDIgADURzxmttZoIRIPWGoQMV00XHWCAQIhXruVWOz0NjlkIA=;K:MDkwEwYHKoZIzj0CAQYIKoZIzj0DAQcDIgADURzxmttZoIRIPWGoQMV00XHWCAQIhXruVWOz0NjlkIA=;;",
+ .expect_fail = true
+ },
+ /* Duplicate frequencies*/
+ {
+ .uri = "DPP:C:81/1,115/36;C:81/1,115/36;;",
+ .expect_fail = true
+ },
+ /* Duplicate MACs*/
+ {
+ .uri = "DPP:M:5254005828e5;M:5254005828e5;;",
+ .expect_fail = true
+ },
+ /* Duplicate versions */
+ {
+ .uri = "DPP:V:2;V:2;;",
+ .expect_fail = true
+ },
+};
+
static bool verify_info(const struct dpp_uri_info *parsed,
const struct dpp_test_info *result)
{
@@ -158,6 +181,14 @@ static void test_bad_channels(const void *data)
test_uri_parse(&bad_channels[i]);
}
+static void test_duplicate_in_uri(const void *data)
+{
+ unsigned int i;
+
+ for (i = 0; i < L_ARRAY_SIZE(duplicates); i++)
+ test_uri_parse(&duplicates[i]);
+}
+
struct dpp_test_vector {
/* Initiator values */
const char *i_proto_public;
@@ -576,6 +607,7 @@ int main(int argc, char *argv[])
l_test_add("DPP URI bad key", test_uri_parse, &bad_key);
l_test_add("DPP URI bad channels", test_bad_channels, &bad_channels);
l_test_add("DPP URI unexpected ID", test_uri_parse, &unexpected_id);
+ l_test_add("DPP URI duplicates", test_duplicate_in_uri, &duplicates);
return l_test_run();
}
--
2.34.1
next prev parent reply other threads:[~2025-04-16 17:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 17:33 [PATCH v2 1/9] monitor: fix spelling Exausted -> Exhausted James Prestwood
2025-04-16 17:33 ` [PATCH v2 2/9] scan: fix out of bound array access for survey results James Prestwood
2025-04-16 17:33 ` [PATCH v2 3/9] dpp-util: fail on duplicate values in URI James Prestwood
2025-04-16 17:33 ` James Prestwood [this message]
2025-04-16 17:33 ` [PATCH v2 5/9] monitor: add size check for interworking IE parsing James Prestwood
2025-04-16 17:33 ` [PATCH v2 6/9] storage: add length check in __storage_decrypt James Prestwood
2025-04-16 17:33 ` [PATCH v2 7/9] unit: add test-storage James Prestwood
2025-04-16 17:33 ` [PATCH v2 8/9] station: check return when advancing iterator James Prestwood
2025-04-16 17:33 ` [PATCH v2 9/9] eap-mschapv2: Fix leak of state->user on error path James Prestwood
2025-04-16 19:58 ` [PATCH v2 1/9] monitor: fix spelling Exausted -> Exhausted Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416173345.136025-4-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox