From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH v2 9/9] eap-mschapv2: Fix leak of state->user on error path
Date: Wed, 16 Apr 2025 10:33:45 -0700 [thread overview]
Message-ID: <20250416173345.136025-9-prestwoj@gmail.com> (raw)
In-Reply-To: <20250416173345.136025-1-prestwoj@gmail.com>
Fixes: 6dc5d2c3 ("eap-mschapv2: Load credentials obtained from agent")
---
src/eap-mschapv2.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/eap-mschapv2.c b/src/eap-mschapv2.c
index 1639f578..00976d73 100644
--- a/src/eap-mschapv2.c
+++ b/src/eap-mschapv2.c
@@ -544,7 +544,8 @@ static bool eap_mschapv2_load_settings(struct eap_state *eap,
return true;
error:
- free(state);
+ l_free(state->user);
+ l_free(state);
return false;
}
--
2.34.1
next prev parent reply other threads:[~2025-04-16 17:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-16 17:33 [PATCH v2 1/9] monitor: fix spelling Exausted -> Exhausted James Prestwood
2025-04-16 17:33 ` [PATCH v2 2/9] scan: fix out of bound array access for survey results James Prestwood
2025-04-16 17:33 ` [PATCH v2 3/9] dpp-util: fail on duplicate values in URI James Prestwood
2025-04-16 17:33 ` [PATCH v2 4/9] unit: add test for duplicate URI elements James Prestwood
2025-04-16 17:33 ` [PATCH v2 5/9] monitor: add size check for interworking IE parsing James Prestwood
2025-04-16 17:33 ` [PATCH v2 6/9] storage: add length check in __storage_decrypt James Prestwood
2025-04-16 17:33 ` [PATCH v2 7/9] unit: add test-storage James Prestwood
2025-04-16 17:33 ` [PATCH v2 8/9] station: check return when advancing iterator James Prestwood
2025-04-16 17:33 ` James Prestwood [this message]
2025-04-16 19:58 ` [PATCH v2 1/9] monitor: fix spelling Exausted -> Exhausted Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250416173345.136025-9-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox