public inbox for iwd@lists.linux.dev
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH v2 02/11] vendor_quirks: implement two vendor quirks
Date: Wed, 27 Aug 2025 05:54:52 -0700	[thread overview]
Message-ID: <20250827125501.477908-2-prestwoj@gmail.com> (raw)
In-Reply-To: <20250827125501.477908-1-prestwoj@gmail.com>

ignore_bss_tm_candidates:
  When a BSS requests a station roam it can optionally include a
  list of BSS's that can be roamed to. IWD uses this list and only
  scans on those frequencies. In some cases though the AP's list
  contains very poor options and it would be better for IWD to
  request a full neighbor report.

replay_counter_mismatch:
  On some Aruba APs there is a mismatch in the replay counters
  between what is seen in scans versus authentications/associations.
  This difference is not allowed in the spec, therefore IWD will
  not connect. This quirk is intended to relax that check.
---
 src/vendor_quirks.c | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/src/vendor_quirks.c b/src/vendor_quirks.c
index 18a9ba7a..4fba0c33 100644
--- a/src/vendor_quirks.c
+++ b/src/vendor_quirks.c
@@ -25,6 +25,7 @@
 #endif
 
 #include <string.h>
+#include <stdio.h>
 
 #include <ell/ell.h>
 
@@ -34,7 +35,16 @@ static const struct {
 	uint8_t oui[3];
 	struct vendor_quirk quirks;
 } oui_quirk_db[] = {
-	{ }
+	{
+		/* Cisco Meraki */
+		{ 0x00, 0x18, 0x0a },
+		{ .ignore_bss_tm_candidates = true },
+	},
+	{
+		/* Hewlett Packard, owns Aruba */
+		{ 0x00, 0x0b, 0x86 },
+		{ .replay_counter_mismatch = true },
+	},
 };
 
 void vendor_quirks_append_for_oui(const uint8_t *oui,
@@ -58,8 +68,15 @@ void vendor_quirks_append_for_oui(const uint8_t *oui,
 const char *vendor_quirks_to_string(struct vendor_quirk quirks)
 {
 	static char out[1024];
+	char *pos = out;
 	size_t s = 0;
 
+	if (quirks.ignore_bss_tm_candidates)
+		s += snprintf(pos, sizeof(out) - s, "IgnoreBssTmCandidateList");
+
+	if (quirks.replay_counter_mismatch)
+		s += snprintf(pos, sizeof(out) - s, "ReplayCounterMismatch");
+
 	if (!s)
 		return NULL;
 
-- 
2.34.1


  reply	other threads:[~2025-08-27 12:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-27 12:54 [PATCH v2 01/11] vendor_quirks: initial skeleton James Prestwood
2025-08-27 12:54 ` James Prestwood [this message]
2025-08-27 12:54 ` [PATCH v2 03/11] handshake: pass object to handshake_util_ap_ie_matches James Prestwood
2025-08-27 12:54 ` [PATCH v2 04/11] handshake: add vendor quirks into handshake object James Prestwood
2025-08-27 12:54 ` [PATCH v2 05/11] scan: store vendor quirks in scan_bss James Prestwood
2025-08-27 12:54 ` [PATCH v2 06/11] station: set vendor quirks into handshake object James Prestwood
2025-08-27 12:54 ` [PATCH v2 07/11] handshake: use vendor quirk to disable check of replay counters James Prestwood
2025-08-27 12:54 ` [PATCH v2 08/11] station: get neighbor report on BSS TM request James Prestwood
2025-08-27 12:54 ` [PATCH v2 09/11] station: check vendor quirk for BSS TM request candidate list James Prestwood
2025-08-27 12:55 ` [PATCH v2 10/11] auto-t: add AP roam test for bad neighbor reports/candidate lists James Prestwood
2025-08-27 12:55 ` [PATCH v2 11/11] station: print vendor quirks (if any) when connecting/roaming James Prestwood
2025-08-27 17:42 ` [PATCH v2 01/11] vendor_quirks: initial skeleton Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250827125501.477908-2-prestwoj@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox