From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>,
Michael Johnson <mjohnson459@gmail.com>
Subject: [PATCH v2 07/11] handshake: use vendor quirk to disable check of replay counters
Date: Wed, 27 Aug 2025 05:54:57 -0700 [thread overview]
Message-ID: <20250827125501.477908-7-prestwoj@gmail.com> (raw)
In-Reply-To: <20250827125501.477908-1-prestwoj@gmail.com>
This has been a long standing issue on Aruba APs where the scan
IEs differ from the IEs received during FT. For compatibility we
have been carrying a patch to disable the replay counter check but
this isn't something that was ever acceptable for upstream. Now
with the addition of vendor quirks this check can be disabled only
for the OUI of Aruba APs.
Reported-by: Michael Johnson <mjohnson459@gmail.com>
Co-authored-by: Michael Johnson <<mjohnson459@gmail.com>
---
src/handshake.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/handshake.c b/src/handshake.c
index 02dfe2d8..ef1a8220 100644
--- a/src/handshake.c
+++ b/src/handshake.c
@@ -914,11 +914,15 @@ bool handshake_util_ap_ie_matches(struct handshake_state *s,
if (msg_info->no_pairwise != scan_info.no_pairwise)
return false;
- if (msg_info->ptksa_replay_counter != scan_info.ptksa_replay_counter)
- return false;
+ if (!(s->vendor_quirks.replay_counter_mismatch)) {
+ if (msg_info->ptksa_replay_counter !=
+ scan_info.ptksa_replay_counter)
+ return false;
- if (msg_info->gtksa_replay_counter != scan_info.gtksa_replay_counter)
- return false;
+ if (msg_info->gtksa_replay_counter !=
+ scan_info.gtksa_replay_counter)
+ return false;
+ }
if (msg_info->mfpr != scan_info.mfpr)
return false;
--
2.34.1
next prev parent reply other threads:[~2025-08-27 12:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 12:54 [PATCH v2 01/11] vendor_quirks: initial skeleton James Prestwood
2025-08-27 12:54 ` [PATCH v2 02/11] vendor_quirks: implement two vendor quirks James Prestwood
2025-08-27 12:54 ` [PATCH v2 03/11] handshake: pass object to handshake_util_ap_ie_matches James Prestwood
2025-08-27 12:54 ` [PATCH v2 04/11] handshake: add vendor quirks into handshake object James Prestwood
2025-08-27 12:54 ` [PATCH v2 05/11] scan: store vendor quirks in scan_bss James Prestwood
2025-08-27 12:54 ` [PATCH v2 06/11] station: set vendor quirks into handshake object James Prestwood
2025-08-27 12:54 ` James Prestwood [this message]
2025-08-27 12:54 ` [PATCH v2 08/11] station: get neighbor report on BSS TM request James Prestwood
2025-08-27 12:54 ` [PATCH v2 09/11] station: check vendor quirk for BSS TM request candidate list James Prestwood
2025-08-27 12:55 ` [PATCH v2 10/11] auto-t: add AP roam test for bad neighbor reports/candidate lists James Prestwood
2025-08-27 12:55 ` [PATCH v2 11/11] station: print vendor quirks (if any) when connecting/roaming James Prestwood
2025-08-27 17:42 ` [PATCH v2 01/11] vendor_quirks: initial skeleton Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250827125501.477908-7-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
--cc=mjohnson459@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox