public inbox for iwd@lists.linux.dev
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH v2 09/11] station: check vendor quirk for BSS TM request candidate list
Date: Wed, 27 Aug 2025 05:54:59 -0700	[thread overview]
Message-ID: <20250827125501.477908-9-prestwoj@gmail.com> (raw)
In-Reply-To: <20250827125501.477908-1-prestwoj@gmail.com>

If the AP vendor has known issues with the preferred candidate list
ignore it and jump directly to requesting a neighbor report.
---
 src/station.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

v2:
 * Reworked to use variable for better readability

diff --git a/src/station.c b/src/station.c
index 3d8eb36b..4a29c9c1 100644
--- a/src/station.c
+++ b/src/station.c
@@ -64,6 +64,7 @@
 #include "src/eap-tls-common.h"
 #include "src/storage.h"
 #include "src/pmksa.h"
+#include "src/vendor_quirks.h"
 
 #define STATION_RECENT_NETWORK_LIMIT	5
 #define STATION_RECENT_FREQS_LIMIT	5
@@ -3266,6 +3267,8 @@ static void station_ap_directed_roam(struct station *station,
 	uint16_t dtimer;
 	uint8_t valid_interval;
 	bool can_roam = !station_cannot_roam(station);
+	bool ignore_candidates =
+		station->connected_bss->vendor_quirks.ignore_bss_tm_candidates;
 
 	l_debug("ifindex: %u", netdev_get_ifindex(station->netdev));
 
@@ -3383,7 +3386,8 @@ static void station_ap_directed_roam(struct station *station,
 	l_timeout_remove(station->roam_trigger_timeout);
 	station->roam_trigger_timeout = NULL;
 
-	if (req_mode & WNM_REQUEST_MODE_PREFERRED_CANDIDATE_LIST) {
+	if ((req_mode & WNM_REQUEST_MODE_PREFERRED_CANDIDATE_LIST) &&
+				!ignore_candidates) {
 		l_debug("roam: AP sent a preferred candidate list");
 		station_neighbor_report_cb(station->netdev, 0, body + pos,
 				body_len - pos, station);
-- 
2.34.1


  parent reply	other threads:[~2025-08-27 12:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-27 12:54 [PATCH v2 01/11] vendor_quirks: initial skeleton James Prestwood
2025-08-27 12:54 ` [PATCH v2 02/11] vendor_quirks: implement two vendor quirks James Prestwood
2025-08-27 12:54 ` [PATCH v2 03/11] handshake: pass object to handshake_util_ap_ie_matches James Prestwood
2025-08-27 12:54 ` [PATCH v2 04/11] handshake: add vendor quirks into handshake object James Prestwood
2025-08-27 12:54 ` [PATCH v2 05/11] scan: store vendor quirks in scan_bss James Prestwood
2025-08-27 12:54 ` [PATCH v2 06/11] station: set vendor quirks into handshake object James Prestwood
2025-08-27 12:54 ` [PATCH v2 07/11] handshake: use vendor quirk to disable check of replay counters James Prestwood
2025-08-27 12:54 ` [PATCH v2 08/11] station: get neighbor report on BSS TM request James Prestwood
2025-08-27 12:54 ` James Prestwood [this message]
2025-08-27 12:55 ` [PATCH v2 10/11] auto-t: add AP roam test for bad neighbor reports/candidate lists James Prestwood
2025-08-27 12:55 ` [PATCH v2 11/11] station: print vendor quirks (if any) when connecting/roaming James Prestwood
2025-08-27 17:42 ` [PATCH v2 01/11] vendor_quirks: initial skeleton Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250827125501.477908-9-prestwoj@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox