From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH v3 1/4] station: check return of handshake_state_set_pmksa
Date: Mon, 9 Mar 2026 09:57:43 -0700 [thread overview]
Message-ID: <20260309165746.2073055-1-prestwoj@gmail.com> (raw)
If this fails num_pmkids and pmkids would get set, but to an
uninitialized buffer. This would then fail to build the handshake
object later when copying the PMKID.
---
src/station.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/station.c b/src/station.c
index 50997f5f..fdd4cda5 100644
--- a/src/station.c
+++ b/src/station.c
@@ -1378,9 +1378,10 @@ build_ie:
bss->ssid, bss->ssid_len,
info.akm_suites);
if (pmksa) {
- handshake_state_set_pmksa(hs, pmksa);
- info.num_pmkids = 1;
- info.pmkids = hs->pmksa->pmkid;
+ if (!L_WARN_ON(!handshake_state_set_pmksa(hs, pmksa))) {
+ info.num_pmkids = 1;
+ info.pmkids = hs->pmksa->pmkid;
+ }
}
}
--
2.34.1
next reply other threads:[~2026-03-09 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 16:57 James Prestwood [this message]
2026-03-09 16:57 ` [PATCH v3 2/4] auto-t: refactor testSAE-roam into connect/roam functions James Prestwood
2026-03-09 16:57 ` [PATCH v3 3/4] auto-t: Add test to roam back to BSS with existing PMKSA James Prestwood
2026-03-09 16:57 ` [PATCH v3 4/4] handshake: clear expiration of pmksa in _steal_pmksa() James Prestwood
2026-03-10 14:33 ` [PATCH v3 1/4] station: check return of handshake_state_set_pmksa Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309165746.2073055-1-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox