public inbox for iwd@lists.linux.dev
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH v3 4/4] handshake: clear expiration of pmksa in _steal_pmksa()
Date: Mon,  9 Mar 2026 09:57:46 -0700	[thread overview]
Message-ID: <20260309165746.2073055-4-prestwoj@gmail.com> (raw)
In-Reply-To: <20260309165746.2073055-1-prestwoj@gmail.com>

When pulling the pmksa out of the handshake object (to cache) we
also need to clear the expiration within the handshake itself. This
will prevent future attempts of setting the PMKSA into the handshake
due to the logic in handshake_state_set_pmksa():

/* checks for both expiration || pmksa being set */
if (s->expiration)
    return false;
---
 src/handshake.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/handshake.c b/src/handshake.c
index ef1a8220..41192fdd 100644
--- a/src/handshake.c
+++ b/src/handshake.c
@@ -1267,6 +1267,7 @@ static struct pmksa *handshake_state_steal_pmksa(struct handshake_state *s)
 
 	pmksa = l_new(struct pmksa, 1);
 	pmksa->expiration = s->expiration;
+	s->expiration = 0;
 	memcpy(pmksa->spa, s->spa, sizeof(s->spa));
 	memcpy(pmksa->aa, s->aa, sizeof(s->aa));
 	memcpy(pmksa->ssid, s->ssid, s->ssid_len);
-- 
2.34.1


  parent reply	other threads:[~2026-03-09 16:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 16:57 [PATCH v3 1/4] station: check return of handshake_state_set_pmksa James Prestwood
2026-03-09 16:57 ` [PATCH v3 2/4] auto-t: refactor testSAE-roam into connect/roam functions James Prestwood
2026-03-09 16:57 ` [PATCH v3 3/4] auto-t: Add test to roam back to BSS with existing PMKSA James Prestwood
2026-03-09 16:57 ` James Prestwood [this message]
2026-03-10 14:33 ` [PATCH v3 1/4] station: check return of handshake_state_set_pmksa Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260309165746.2073055-4-prestwoj@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox