[PATCH v3 1/4] station: check return of handshake_state_set_pmksa

James Prestwood
2026-03-09T16:57:53Z

If this fails num_pmkids and pmkids would get set, but to an
uninitialized buffer. This would then fail to build the handshake
object later when copying the PMKID.
---
src/station.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/station.c b/src/station.c
index 50997f5f..fdd4cda5 100644
--- a/src/station.c
+++ b/src/station.c
@@ -1378,9 +1378,10 @@ build_ie:
bss->ssid, bss->ssid_len,
info.akm_suites);
if (pmksa) {
- handshake_state_set_pmksa(hs, pmksa);
- info.num_pmkids = 1;
- info.pmkids = hs->pmksa->pmkid;
+ if (!L_WARN_ON(!handshake_state_set_pmksa(hs, pmksa))) {
+ info.num_pmkids = 1;
+ info.pmkids = hs->pmksa->pmkid;
+ }
}
}

--
2.34.1