[PATCH] auto-t: fix two issues with testAPRoam

[PATCH] auto-t: fix two issues with testAPRoam

[James Prestwood]

One of the tests expects a roam to a certain BSS, but there's an
extra hostapd instance (use by another test) making it random which
BSS IWD roams to. This hostapd instance has been disabled for this
test.

The second issue was waiting for the no-roam-candidates event. The
default wait is 10 seconds, which can sometimes take longer since
IWD will perform a full scan after a roam scan. Increase this timeout
to 20 seconds to guard against that.
---
 autotests/testAPRoam/connection_test.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/autotests/testAPRoam/connection_test.py b/autotests/testAPRoam/connection_test.py
index 1f95fb96..b55b8455 100644
--- a/autotests/testAPRoam/connection_test.py
+++ b/autotests/testAPRoam/connection_test.py
@@ -40,7 +40,7 @@ class Test(unittest.TestCase):
 
             to_bss.wait_for_event('AP-STA-CONNECTED %s' % self.device.address)
         else:
-            self.device.wait_for_event("no-roam-candidates")
+            self.device.wait_for_event("no-roam-candidates", timeout=20)
 
     def test_disassoc_imminent(self):
         self.initial_connection()
@@ -76,6 +76,8 @@ class Test(unittest.TestCase):
             (cls.bss_hostapd[1].bssid, "8f0000005102060603000000"),
         ]
 
+        cls.bss_hostapd[2].disable()
+
     @classmethod
     def tearDownClass(cls):
         IWD.clear_storage()
-- 
2.34.1

Re: [PATCH] auto-t: fix two issues with testAPRoam

[Marcel Holtmann]

Hi James,

> One of the tests expects a roam to a certain BSS, but there's an
> extra hostapd instance (use by another test) making it random which
> BSS IWD roams to. This hostapd instance has been disabled for this
> test.
> 
> The second issue was waiting for the no-roam-candidates event. The
> default wait is 10 seconds, which can sometimes take longer since
> IWD will perform a full scan after a roam scan. Increase this timeout
> to 20 seconds to guard against that.
> ---
> autotests/testAPRoam/connection_test.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

patch has been applied.

Regards

Marcel