From: Dierk Modrow <dierk.modrow@gmail.com>
To: iwd@lists.linux.dev
Cc: pmenzel@molgen.mpg.de, Dierk Modrow <dierk.modrow@sew-eurodrive.de>
Subject: [PATCH 2/2] src/station.c: fix of SEGV in station_roam_scan_notify when performing repeated roam scan at legacy roaming after ft_auth-/ft_reassoc-timeout when using mwifiex / NXP 88W9098 driver
Date: Wed, 8 Jul 2026 17:22:28 +0200 [thread overview]
Message-ID: <20260708152228.1191-2-dierk.modrow@gmail.com> (raw)
In-Reply-To: <20260708152228.1191-1-dierk.modrow@gmail.com>
From: Dierk Modrow <dierk.modrow@sew-eurodrive.de>
---
src/station.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/station.c b/src/station.c
index 8fcf8c70..077e510e 100644
--- a/src/station.c
+++ b/src/station.c
@@ -2253,7 +2253,7 @@ static bool station_can_fast_transition(struct station *station,
{
uint16_t mdid;
- if (!hs->mde)
+ if (!hs || !hs->mde)
return false;
if (ie_parse_mobility_domain_from_data(hs->mde, hs->mde[1] + 2,
@@ -2917,7 +2917,7 @@ static bool station_roam_scan_notify(int err, struct l_queue *bss_list,
orig_security = network_get_security(network);
- if (hs->mde)
+ if (hs && hs->mde)
ie_parse_mobility_domain_from_data(hs->mde, hs->mde[1] + 2,
&mdid, NULL, NULL);
@@ -2930,7 +2930,7 @@ static bool station_roam_scan_notify(int err, struct l_queue *bss_list,
if (bss && !station->ap_directed_roaming) {
double cur_bss_rank = bss->rank;
- if (hs->mde && bss->mde_present && l_get_le16(bss->mde) == mdid)
+ if (hs && hs->mde && bss->mde_present && l_get_le16(bss->mde) == mdid)
cur_bss_rank *= RANK_FT_FACTOR;
cur_bss_group_rank = evaluate_bss_group_rank(bss->addr,
@@ -2967,8 +2967,8 @@ static bool station_roam_scan_notify(int err, struct l_queue *bss_list,
goto next;
/* Skip result if it is not part of the ESS */
- if (bss->ssid_len != hs->ssid_len ||
- memcmp(bss->ssid, hs->ssid, hs->ssid_len))
+ if (hs && (bss->ssid_len != hs->ssid_len ||
+ memcmp(bss->ssid, hs->ssid, hs->ssid_len)))
goto next;
if (scan_bss_get_security(bss, &security) < 0)
@@ -2986,7 +2986,7 @@ static bool station_roam_scan_notify(int err, struct l_queue *bss_list,
rank = bss->rank;
- if (hs->mde && bss->mde_present && l_get_le16(bss->mde) == mdid)
+ if (hs && hs->mde && bss->mde_present && l_get_le16(bss->mde) == mdid)
rank *= RANK_FT_FACTOR;
group_rank = evaluate_bss_group_rank(bss->addr, bss->frequency,
--
2.53.0.windows.2
next prev parent reply other threads:[~2026-07-08 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 15:22 [PATCH] src/eapol.c: fix of SEGV in eapol_rx_packets at receipt of EAPOL M1 msg at legacy roaming after ft_auth-/ft_reassoc-timeout when using mwifiex / NXP 88W9098 driver Dierk Modrow
2026-07-08 15:22 ` Dierk Modrow [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-07-13 11:22 [PATCH 1/2] " Dierk Modrow
2026-07-13 11:22 ` [PATCH 2/2] src/station.c: fix of SEGV in station_roam_scan_notify when performing repeated roam scan " Dierk Modrow
2026-07-13 11:29 [PATCH 1/2] src/eapol.c: fix of SEGV in eapol_rx_packets at receipt of EAPOL M1 msg " Dierk Modrow
2026-07-13 11:29 ` [PATCH 2/2] src/station.c: fix of SEGV in station_roam_scan_notify when performing repeated roam scan " Dierk Modrow
2026-07-13 11:35 [PATCH 1/2] src/eapol.c: fix of SEGV in eapol_rx_packets at receipt of EAPOL M1 msg " Dierk Modrow
2026-07-13 11:35 ` [PATCH 2/2] src/station.c: fix of SEGV in station_roam_scan_notify when performing repeated roam scan " Dierk Modrow
2026-07-14 13:37 ` James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708152228.1191-2-dierk.modrow@gmail.com \
--to=dierk.modrow@gmail.com \
--cc=dierk.modrow@sew-eurodrive.de \
--cc=iwd@lists.linux.dev \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox