Re: [PATCH 1/3] hwsim: remove 'optimization' sending to only known MACs

[Denis Kenzior <denkenz@gmail.com>]

Hi James,

>> You can try to see whether HWSIM_CMD_ADD_MAC_ADDR works?  See commit 
>> 5cc58a9ecfa1 ("mac80211_hwsim: notify wmediumd of used MAC addresses")
> 
> I hadn't seen that before, but looking at it they don't expose that as an API, 
> its only for internal use for scan address randomization and monitor interfaces 
> (see mac80211_hwsim_config_mac_nl()).
> 

It is used as an unsolicited event / notification.  Yeah I know, HWSIM_CMD_* 
prefix is confusing ;)

It looks like we should start using this since most of our autotests are forced 
to include the following main.conf:

[Scan]
DisableMacAddressRandomization=true

Having support for the above event would allow us to get rid of this hack.

<snip>

>>
>> Hmm, but radios are namespace independent.  They can only be added/removed via 
>> HWSIM_CMD_ADD/DEL_RADIO, no?  Since phys are moved wholesale across namespaces 
>> (you can't only move a given interface), you could assume that once a radio is 
>> created and populated, its interfaces do not change for the duration of the 
>> test, even if they're moved to a different namespace.
> 
> For testing yes this is probably fine. It may require some adaptation in hwsim 
> to do it better from a test-runner perspective. Currently we just use ip to 
> create/delete namespaces and move radios. It may make more sense to add this to 
> hwsim so there is one path. Then at least when hwsim gets a DEL_WIPHY event it 

It shouldn't matter really who invokes the namespace move.  hwsim would know 
whether it is a hot-unplug or a namespace move by virtue of being the one who 
triggers HWSIM_CMD_DEL_RADIO.

> doesn't have to assume the radio was moved (I'm thinking if we ever added 
> hotplug tests this could be important).

We should add these, but the above still stands.  hwsim is the only thing in our 
tests that triggers HWSIM_CMD_ADD_RADIO.

Regards,
-Denis