From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH v3 1/2] eap-tls-common: update to new ELL TLS APIs
Date: Wed, 02 Oct 2019 10:43:13 -0500 [thread overview]
Message-ID: <294fb92d-6673-22c5-e5a1-cc6270157938@gmail.com> (raw)
In-Reply-To: <20191001213809.8471-1-prestwoj@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 784 bytes --]
Hi James,
On 10/1/19 4:38 PM, James Prestwood wrote:
> ---
> src/eap-tls-common.c | 20 ++++++++++++++------
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
> -v3:
> * Fixed the ca_cert cleanup, l_certchain_free was being used rather
> than l_cert_free.
>
I ended up pushing my own version of this that was extra paranoid. The
issue is that since the certificates are on disk, we can't simply assume
that they will be loaded successfully (as they might have been
inadvertently or maliciously changed between the time check_settings and
tunnel_init are called).
It might actually make sense to load the keys at load_settings time or
(or even earlier) to avoid extra latency during connection setup time.
Please review.
Regards,
-Denis
prev parent reply other threads:[~2019-10-02 15:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 21:38 [PATCH v3 1/2] eap-tls-common: update to new ELL TLS APIs James Prestwood
2019-10-01 21:38 ` [PATCH v3 2/2] unit: update test-eapol to new ELL APIs James Prestwood
2019-10-02 15:38 ` Denis Kenzior
2019-10-02 15:43 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=294fb92d-6673-22c5-e5a1-cc6270157938@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox