From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH 1/2] auto-t: fix hostapd.ungraceful_restart
Date: Wed, 15 Jul 2020 14:44:11 -0500 [thread overview]
Message-ID: <2cd0d2f0-e565-6d76-636d-0ac1cf9e59d8@gmail.com> (raw)
In-Reply-To: <20200714184908.2776-1-prestwoj@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 808 bytes --]
Hi James,
On 7/14/20 1:49 PM, James Prestwood wrote:
> Restarting hostapd from python was actually leaking memory and
> causing the hostapd object to stay referenced in python. The
> GLib timeout in wait_for_event was the ultimate cause, but this
> had no come to light because no tests restarted hostapd then
> used wait_for_event.
>
> In addition, any use of wait_for_event after a restart would
> cause an exception because the event socket was never re-attached
> after hostapd restarted.
>
> Now we properly clean up the timeout in wait_for_event and
> re-initialize the hostapd object on restart.
> ---
> autotests/util/hostapd.py | 39 +++++++++++++++++++++++++++++----------
> 1 file changed, 29 insertions(+), 10 deletions(-)
>
Both applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2020-07-15 19:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 18:49 [PATCH 1/2] auto-t: fix hostapd.ungraceful_restart James Prestwood
2020-07-14 18:49 ` [PATCH 2/2] auto-t: make testSAQuery more reliable James Prestwood
2020-07-15 19:44 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cd0d2f0-e565-6d76-636d-0ac1cf9e59d8@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox