Re: [PATCH 1/5] defs: Add defs.h to hold certain global definitions

Denis Kenzior
2024-08-23T17:24:14Z

On 8/23/24 11:18 AM, Denis Kenzior wrote:
> This will help to get rid of magic number use throughout the project.
> The definitions should be limited to global magic numbers that are used
> throughout the project, for example SSID length, MAC address length,
> etc.
> ---
> Makefile.am | 3 ++-
> src/ap.c | 8 ++++----
> src/crypto.c | 3 ++-
> src/defs.h | 13 +++++++++++++
> src/dpp-util.h | 5 ++++-
> src/eap-wsc.c | 4 ++--
> src/handshake.h | 2 +-
> src/ie.c | 2 +-
> src/ie.h | 3 ++-
> src/knownnetworks.h | 4 +++-
> src/network.c | 2 +-
> src/p2putil.h | 3 ++-
> src/rrm.c | 4 ++--
> src/scan.c | 2 +-
> src/scan.h | 4 +++-
> src/station.c | 4 ++--
> src/storage.c | 3 ++-
> src/util.c | 5 +++--
> src/wsc.h | 2 +-
> src/wscutil.c | 2 +-
> src/wscutil.h | 4 +++-
> unit/test-util.c | 3 ++-
> 22 files changed, 57 insertions(+), 28 deletions(-)
> create mode 100644 src/defs.h
>

All applied