From: Denis Kenzior <denkenz at gmail.com>
To: iwd at lists.01.org
Subject: Re: [PATCH 2/3] scan: set scan priority via scan_common
Date: Tue, 11 Jan 2022 09:07:20 -0600 [thread overview]
Message-ID: <451616f8-9402-c544-8ac8-cebc6bfee298@gmail.com> (raw)
In-Reply-To: 20220111001519.1013183-2-prestwoj@gmail.com
[-- Attachment #1: Type: text/plain, Size: 700 bytes --]
On 1/10/22 18:15, James Prestwood wrote:
> This adds a priority argument to scan_common rather than hard
> coding it when inserting the work item
> ---
> src/scan.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)
>
> diff --git a/src/scan.c b/src/scan.c
> index 54159dfd..96907e59 100644
> --- a/src/scan.c
> +++ b/src/scan.c
> @@ -52,6 +52,8 @@
> #include "src/band.h"
> #include "src/scan.h"
>
> +#define SCAN_WORK_PRIORITY 2
Can we name this SCAN_REQUEST_PRIORITY, or even simply REQUEST_PRIORITY?
Also, I wonder if we should put the priority numbers into wiphy.h instead of
relying on hard-coded 1/2/3 everywhere.
Regards,
-Denis
next reply other threads:[~2022-01-11 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 15:07 Denis Kenzior [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-11 0:15 [PATCH 2/3] scan: set scan priority via scan_common James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451616f8-9402-c544-8ac8-cebc6bfee298@gmail.com \
--to=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox