From: Denis Kenzior <denkenz@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, iwd@lists.linux.dev
Cc: Daniel Bond <danielbondno@gmail.com>
Subject: Re: [PATCH 1/2] scan: check scan request in get_survey_done before deref
Date: Thu, 5 Sep 2024 09:57:48 -0500 [thread overview]
Message-ID: <4d66fa8f-7499-4d68-9087-6e3bf6aa876e@gmail.com> (raw)
In-Reply-To: <1fc65fe7-3e6f-4953-973c-84bde72bb2d1@gmail.com>
Hi James,
>> Do we know why external scans are happening? I can understand a one off
>> because someone triggered iw scan, but from the bug report it sounded like it
>> was crashing iwd repeatedly?
> NetworkManager? wpa_supplicant running? I really have no idea. Either way its
> out of our control.
Would be good to know and fix that.
>>
>> I still don't understand why we're even bothering requesting a survey for a
>> scan we didn't trigger? In other words, we shouldn't even be in this function.
> Because we still utilize external scan results for periodic scans. So if
> periodic scans are running we will still try and get the survey/results.
Should we though? I'm not really sure how surveys are implemented at the driver
level. Are you sure this isn't introducing other timing problems?
Regards,
-Denis
next prev parent reply other threads:[~2024-09-05 14:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 13:43 [PATCH 1/2] scan: check scan request in get_survey_done before deref James Prestwood
2024-09-05 13:43 ` [PATCH 2/2] scan: check pending requests after regdom update James Prestwood
2024-09-05 13:56 ` [PATCH 1/2] scan: check scan request in get_survey_done before deref James Prestwood
2024-09-05 14:37 ` Denis Kenzior
2024-09-05 14:44 ` James Prestwood
2024-09-05 14:57 ` Denis Kenzior [this message]
2024-09-05 15:09 ` James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d66fa8f-7499-4d68-9087-6e3bf6aa876e@gmail.com \
--to=denkenz@gmail.com \
--cc=danielbondno@gmail.com \
--cc=iwd@lists.linux.dev \
--cc=prestwoj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox