Wireless Daemon for Linux
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [RFCv3] Document P2P dbus interfaces
Date: Fri, 15 Nov 2019 09:25:30 -0600	[thread overview]
Message-ID: <4fcb640d-2255-83a3-044c-b5ad92e9b6d4@gmail.com> (raw)
In-Reply-To: <CAOq732JU_+kDbH0FD3AxRscBn8CUpi8Cntf7GycymCSgVJzgfg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]

Hi Andrew,

>> Station.Disconnect does not affect WSC state FYI.  It can't since
>> Station doesn't even know about the ongoing WSC process until after
>> station_connect_network is invoked.  So in that respect we'd be
>> completely consistent.
> 
> What I meant is that Disconnect() can cancel your station connection
> attempt at any point, while with Peer.Disconnect() you're going to
> have to be more careful for no reason.

You will have to explain that then, because I don't get it?  How is 
Peer.Disconnect any different?  Your 'Peer' state doesn't change to 
connecting until after WSC runs.  And if we become a GO, then things 
become even more funny since we can only send invites, not actually 
initiate a connection.  So all these methods become somewhat irrelevant. 
  In fact, I wonder if we should be removing the WSC interface when we 
become the GO and adding another one for performing invitations.

> I was just noting they're not happening on different interfaces.

Of course.  That's because P2P_CLIENT is just a station iftype under the 
hood in the kernel with some extra stuff bolted on.  But we knew that ;)

Maybe what we should do is just implement the bare minimum client side 
API, learn from it and assume that whatever API we come up with now will 
likely not survive when we start implementing GO side.

Regards,
-Denis

  reply	other threads:[~2019-11-15 15:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-10 20:51 [RFCv3] Document P2P dbus interfaces Andrew Zaborowski
2019-11-14  4:40 ` Denis Kenzior
2019-11-14 16:59   ` Andrew Zaborowski
2019-11-14 18:19     ` Denis Kenzior
2019-11-14 19:37       ` Andrew Zaborowski
2019-11-14 20:33         ` Denis Kenzior
2019-11-15  0:38           ` Andrew Zaborowski
2019-11-15  3:25             ` Denis Kenzior
2019-11-15  4:02               ` Andrew Zaborowski
2019-11-15  5:08                 ` Denis Kenzior
2019-11-15 12:33                   ` Andrew Zaborowski
2019-11-15 14:51                     ` Denis Kenzior
2019-11-15 15:10                       ` Andrew Zaborowski
2019-11-15 15:25                         ` Denis Kenzior [this message]
2019-11-15 22:35                           ` Andrew Zaborowski
2019-11-16  2:27                             ` Denis Kenzior
2019-11-16  3:02                               ` Andrew Zaborowski
2019-11-16  4:10                                 ` Denis Kenzior
2019-11-16 23:57                                   ` Andrew Zaborowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fcb640d-2255-83a3-044c-b5ad92e9b6d4@gmail.com \
    --to=denkenz@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox