Wireless Daemon for Linux
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH v2 03/13] nl80211util: add nl80211_parse_supported_frequencies
Date: Thu, 4 Aug 2022 10:27:01 -0500	[thread overview]
Message-ID: <50dc2a0a-dc46-49b2-2bdf-bf079242579b@gmail.com> (raw)
In-Reply-To: <20220803213644.277534-3-prestwoj@gmail.com>

Hi James,

On 8/3/22 16:36, James Prestwood wrote:
> A helper function to parse supported and disabled frequencies.
> ---
>   src/nl80211util.c | 45 +++++++++++++++++++++++++++++++++++++++++++++
>   src/nl80211util.h |  4 ++++
>   2 files changed, 49 insertions(+)
> 

<snip>

> +int nl80211_parse_supported_frequencies(struct l_genl_attr *band_freqs,
> +					struct scan_freq_set *supported_list,
> +					struct scan_freq_set *disabled_list)
> +{
> +	uint16_t type, len;
> +	const void *data;
> +	struct l_genl_attr attr;
> +	struct l_genl_attr nested;
> +
> +	if (!l_genl_attr_recurse(band_freqs, &nested))
> +		return -EBADMSG;
> +
> +	while (l_genl_attr_next(&nested, NULL, NULL, NULL)) {
> +		uint32_t freq = 0;
> +		bool disabled = false;
> +
> +		if (!l_genl_attr_recurse(&nested, &attr))
> +			continue;
> +
> +		while (l_genl_attr_next(&attr, &type, &len, &data)) {
> +

I squished this empty line when applying.

> +			switch (type) {
> +			case NL80211_FREQUENCY_ATTR_FREQ:
> +				freq = *((uint32_t *) data);
> +				break;
> +			case NL80211_FREQUENCY_ATTR_DISABLED:
> +				disabled = true;
> +				break;
> +			}
> +		}
> +

Patches 1-5 applied, thanks.

Regards,
-Denis

  reply	other threads:[~2022-08-04 15:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-03 21:36 [PATCH v2 01/13] wiphy: fix runtime error from bit shift James Prestwood
2022-08-03 21:36 ` [PATCH v2 02/13] scan: track scanned frequencies for entire request James Prestwood
2022-08-03 21:36 ` [PATCH v2 03/13] nl80211util: add nl80211_parse_supported_frequencies James Prestwood
2022-08-04 15:27   ` Denis Kenzior [this message]
2022-08-03 21:36 ` [PATCH v2 04/13] wiphy: track self-managed flag James Prestwood
2022-08-03 21:36 ` [PATCH v2 05/13] wiphy: use nl80211_parse_supported_frequencies James Prestwood
2022-08-03 21:36 ` [PATCH v2 06/13] wiphy: add two regulatory domain state events James Prestwood
2022-08-04 15:31   ` Denis Kenzior
2022-08-03 21:36 ` [PATCH v2 07/13] wiphy: dump wiphy's on regulatory domain change James Prestwood
2022-08-03 21:36 ` [PATCH v2 08/13] wiphy: add wiphy_regdom_is_updating James Prestwood
2022-08-03 21:36 ` [PATCH v2 09/13] wiphy: add wiphy_country_is_unknown James Prestwood
2022-08-04 16:48   ` Denis Kenzior
2022-08-03 21:36 ` [PATCH v2 10/13] station: do full passive scan if 6GHz is supported but disabled James Prestwood
2022-08-03 21:36 ` [PATCH v2 11/13] scan: split full scans by band to enable 6GHz James Prestwood
2022-08-03 21:36 ` [PATCH v2 12/13] scan: watch for regdom updates " James Prestwood
2022-08-03 21:36 ` [PATCH v2 13/13] wiphy: don't re-dump wiphy if the regdom didn't change James Prestwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50dc2a0a-dc46-49b2-2bdf-bf079242579b@gmail.com \
    --to=denkenz@gmail.com \
    --cc=iwd@lists.linux.dev \
    --cc=prestwoj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox