Wireless Daemon for Linux
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH 1/2] auto-t: wait for mode change to finish on stop_ap
Date: Mon, 26 Oct 2020 11:11:41 -0700	[thread overview]
Message-ID: <51f2edc3d7e2d6b949077fa0749eaf47abbf3bce.camel@gmail.com> (raw)
In-Reply-To: <20201023221900.1974722-1-prestwoj@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1030 bytes --]

You can leave this patch out actually. Andrew pointed out that any DBus
method call is synchronous if the reply handlers are left out. But
patch 2/2 is still needed.

On Fri, 2020-10-23 at 15:18 -0700, James Prestwood wrote:
> ---
>  autotests/util/iwd.py | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/autotests/util/iwd.py b/autotests/util/iwd.py
> index 9bfc8c1a..c65dd4a2 100755
> --- a/autotests/util/iwd.py
> +++ b/autotests/util/iwd.py
> @@ -481,7 +481,10 @@ class Device(IWDDBusAbstract):
>          self._wait_for_async_op()
>  
>      def stop_ap(self):
> -        self._prop_proxy.Set(IWD_DEVICE_INTERFACE, 'Mode',
> 'station')
> +        self._prop_proxy.Set(IWD_DEVICE_INTERFACE, 'Mode',
> 'station',
> +                                reply_handler=self._success,
> +                                error_handler=self._failure)
> +        self._wait_for_async_op()
>  
>      def connect_hidden_network(self, name):
>          '''Connect to a hidden network

      parent reply	other threads:[~2020-10-26 18:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-23 22:18 [PATCH 1/2] auto-t: wait for mode change to finish on stop_ap James Prestwood
2020-10-23 22:19 ` [PATCH 2/2] auto-t: only return expected number from list_devices James Prestwood
2020-10-26 19:27   ` Denis Kenzior
2020-10-26 18:11 ` James Prestwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51f2edc3d7e2d6b949077fa0749eaf47abbf3bce.camel@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox