[PATCH 7/9] unit: add test-storage

James Prestwood
2025-04-16T12:34:25Z

For now, a single test for __storage_decrypt that ensures an
invalid length fails as expected.
---
Makefile.am | 7 +++++-
unit/test-storage.c | 55 +++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 61 insertions(+), 1 deletion(-)
create mode 100644 unit/test-storage.c

diff --git a/Makefile.am b/Makefile.am
index 6404bdbb..92adfa6e 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -441,7 +441,7 @@ unit_tests += unit/test-cmac-aes \
unit/test-arc4 unit/test-wsc unit/test-eap-mschapv2 \
unit/test-eap-sim unit/test-sae unit/test-p2p unit/test-band \
unit/test-dpp unit/test-json unit/test-nl80211util \
- unit/test-pmksa
+ unit/test-pmksa unit/test-storage
endif

if CLIENT
@@ -605,6 +605,11 @@ unit_test_nl80211util_LDADD = $(ell_ldadd)
unit_test_pmksa_SOURCES = unit/test-pmksa.c src/pmksa.c src/pmksa.h \
src/module.h src/util.h
unit_test_pmksa_LDADD = $(ell_ldadd)
+
+unit_test_storage_SOURCES = unit/test-storage.c src/storage.c src/storage.h \
+ src/crypto.c src/crypto.h \
+ src/common.c src/common.h
+unit_test_storage_LDADD = $(ell_ldadd)
endif

if CLIENT
diff --git a/unit/test-storage.c b/unit/test-storage.c
new file mode 100644
index 00000000..c40518e6
--- /dev/null
+++ b/unit/test-storage.c
@@ -0,0 +1,55 @@
+/*
+ *
+ * Wireless daemon for Linux
+ *
+ * Copyright (C) 2025 Locus Robotics. All rights reserved.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ *
+ */
+
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
+
+#include <assert.h>
+
+#include <ell/ell.h>
+
+#include "src/storage.h"
+
+static void test_short_encrypted_bytes(const void *data)
+{
+ struct l_settings *settings = l_settings_new();
+ bool changed;
+
+ l_settings_set_string(settings, "Security", "EncryptedSecurity", "012345");
+ l_settings_set_string(settings, "Security", "EncryptedSalt", "012345");
+
+ assert(__storage_decrypt(settings, "mySSID", &changed) < 0);
+ l_settings_free(settings);
+}
+
+int main(int argc, char *argv[])
+{
+ l_test_init(&argc, &argv);
+
+ storage_init((const uint8_t *)"abc123", 6);
+
+ l_test_add("/storage/profile encryption",
+ test_short_encrypted_bytes, NULL);
+
+ return l_test_run();
+}
--
2.34.1