Re: [PATCH v2 1/2] hwsim: allow concurrent radio creations

[Denis Kenzior <denkenz at gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 988 bytes --]

Hi James,

On 2/15/22 13:16, James Prestwood wrote:
> Hi Denis,
> 
>>
>>> +       } else if (!rec)
>>> +               return;
>>
>> This part seems suspicious.  What if the radio is being created
>> outside hwsim?
> 
> I guess this is changing behavior... Currently we would still create
> the radio info object if the radio was created externally. Keeping this
> behavior will end up requiring creating the radio here and in
> CreateRadio(), nearly the same as what we had before.
> 

CreateRadio really only creates a stub.  What is there to duplicate besides 
l_new and setting the name/id?

> I guess its up to you. Either we don't support external radio creation
> for cleaner code, or we go back to the way it was (or some variant of
> it).
> 

Clearly we want to support this since hwsim might start with radios already 
created and this path is being used by the initial radio dump (started in 
hwsim_ready).

Regards,
-Denis