Re: [PATCH v2] offchannel: introduce new offchannel module

[James Prestwood <prestwoj at gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]

On Mon, 2021-12-06 at 12:48 -0600, Denis Kenzior wrote:
> Hi James,
> 
> > Even with this though I don't see a point of waiting for the ACK
> > since
> > the kernel will send cancel ROC. The ACK callback for this would
> > have
> > no purpose AFAIK.
> > 
> 
> If you always want to wait for the cancel event, then I would
> concur.  Question 
> is whether the kernel would always guarantee that this is sent.  I
> guess we'll 
> find out :)
> 
> > 
> > Yes, I need to only cancel conditionally. I don't see why we need
> > to
> > invoke destroy here though? I would rather keep destroy() in one
> > location, in the work done callback.
> 
> Mostly to be nice to the consumer of these methods.  They may want to
> assume 
> that cancel succeeds synchronously and that the destroy method is
> invoked right 
> away.  For example, this may be useful if the destroy method
> manipulates some 
> data hanging off the main object and the main object is about to be
> destroyed 
> (hence the cancel call on the ongoing request).

Ok makes sense. I guess in this case we can just call then NULL destroy
and all other cases it will still happen in the work done callback.
I've already sent v3 but I'll update this in the next round.

> 
> Regards,
> -Denis