From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH 07/11] ap: Stop ongoing handshake on reassociation
Date: Thu, 27 Aug 2020 14:11:24 -0500 [thread overview]
Message-ID: <6b5eaab9-a7fd-ca7d-1f3a-c8dab2a8263c@gmail.com> (raw)
In-Reply-To: <20200827181453.61823-7-andrew.zaborowski@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1943 bytes --]
Hi Andrew,
On 8/27/20 1:14 PM, Andrew Zaborowski wrote:
> On a new association or re-association, in addition to forgetting a
> complete RSN Association, also stop the EAPoL SM to stop any ongoing
> handshake.
>
> Do this in a new function ap_stop_handshake that is now used in a few
> places that had copies of the same few lines. I'll be adding some more
> lines to this function for WSC support.
> ---
> src/ap.c | 51 +++++++++++++++++++++++++--------------------------
> 1 file changed, 25 insertions(+), 26 deletions(-)
>
> diff --git a/src/ap.c b/src/ap.c
> index aef2e1dd..5cd2b717 100644
> --- a/src/ap.c
> +++ b/src/ap.c
No real concerns on the first three uses, but...
<snip>
> @@ -938,6 +933,12 @@ static void ap_assoc_reassoc(struct sta_state *sta, bool reassoc,
> goto unsupported;
> }
>
> + /* 802.11-2016 11.3.5.3 j) */
> + if (sta->rsna)
> + ap_drop_rsna(sta);
> +
> + ap_stop_handshake(sta);
> +
ap_drop_rsna also destroys eapol_sm and the handshake object. So perhaps you
need to track the authorized state to choose the right cleanup action?
> if (!sta->associated) {
> /*
> * Everything fine so far, assign an AID, send response.
> @@ -961,10 +962,6 @@ static void ap_assoc_reassoc(struct sta_state *sta, bool reassoc,
>
> sta->assoc_rsne = l_memdup(rsn, rsn[1] + 2);
>
> - /* 802.11-2016 11.3.5.3 j) */
> - if (sta->rsna)
> - ap_drop_rsna(sta);
> -
> sta->assoc_resp_cmd_id = ap_assoc_resp(ap, sta, sta->addr, sta->aid, 0,
> reassoc,
> ap_success_assoc_resp_cb);
> @@ -987,8 +984,10 @@ bad_frame:
> *
> * For now, we need to drop the RSNA.
> */
> - if (sta->associated && sta->rsna)
> + if (sta->associated && sta->rsna) {
> ap_drop_rsna(sta);
> + ap_stop_handshake(sta);
> + }
Same question here?
>
> if (rates)
> l_uintset_free(rates);
>
Regards,
-Denis
next prev parent reply other threads:[~2020-08-27 19:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 18:14 [PATCH 01/11] wscutil: Add wsc_build_beacon Andrew Zaborowski
2020-08-27 18:14 ` [PATCH 02/11] eap: Re-send Identity Request on EAPoL-Start Andrew Zaborowski
2020-08-27 18:53 ` Denis Kenzior
2020-08-27 20:47 ` Andrew Zaborowski
2020-08-27 20:38 ` Denis Kenzior
2020-08-27 23:24 ` Andrew Zaborowski
2020-08-27 18:14 ` [PATCH 03/11] eap-wsc: In WSC-R read UUID-E from settings Andrew Zaborowski
2020-08-27 19:03 ` Denis Kenzior
2020-08-27 18:14 ` [PATCH 04/11] ap: Move AP parameters to a struct Andrew Zaborowski
2020-08-27 19:00 ` Denis Kenzior
2020-08-27 18:14 ` [PATCH 05/11] ap: Drop unused variable Andrew Zaborowski
2020-08-27 18:14 ` [PATCH 06/11] ap: Fix incoming Probe Request BSSID check Andrew Zaborowski
2020-08-27 18:14 ` [PATCH 07/11] ap: Stop ongoing handshake on reassociation Andrew Zaborowski
2020-08-27 19:11 ` Denis Kenzior [this message]
2020-08-27 20:40 ` Andrew Zaborowski
2020-08-27 18:14 ` [PATCH 08/11] ap: Push Button mode API and beacon changes Andrew Zaborowski
2020-08-27 19:42 ` Denis Kenzior
2020-08-27 20:57 ` Andrew Zaborowski
2020-08-27 20:51 ` Denis Kenzior
2020-08-27 18:14 ` [PATCH 09/11] ap: WSC Probe Request processing logic Andrew Zaborowski
2020-08-27 18:14 ` [PATCH 10/11] ap: Parse WSC PBC association request and build response Andrew Zaborowski
2020-08-27 18:14 ` [PATCH 11/11] ap: Start EAP-WSC authentication with WSC enrollees Andrew Zaborowski
2020-08-27 19:16 ` [PATCH 01/11] wscutil: Add wsc_build_beacon Denis Kenzior
2020-08-27 23:18 ` Andrew Zaborowski
2020-08-28 0:12 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b5eaab9-a7fd-ca7d-1f3a-c8dab2a8263c@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox