public inbox for iwd@lists.linux.dev
 help / color / mirror / Atom feed
From: Fiona Klute <fiona.klute@gmx.de>
To: Denis Kenzior <denkenz@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH] Log falling back from SAE to WPA2
Date: Wed, 10 Jan 2024 12:33:08 +0100	[thread overview]
Message-ID: <755dc5bf-1ac7-4eeb-ab16-8ded3aa6a25f@gmx.de> (raw)
In-Reply-To: <214422a4-25bc-4676-8a4a-8bf8d67c7ab9@gmail.com>

Hi Denis,

thanks for accepting the patch!

Am 10.01.24 um 04:33 schrieb Denis Kenzior:
> Interesting.  Last time I checked only the quantenna driver used this
> feature and it wasn't very common.  If it isn't a secret, what card /
> driver do you have?

It's the RTL8723CS chip used in Pinephone, the rtl8723cs driver
unfortunately still isn't in mainline. You can find it in the staging
directory of megi's tree:
https://codeberg.org/megi/linux/src/commit/f45c45abc5325682d06cb51c06aba1f817fba462/drivers/staging/rtl8723cs

I suspect getting the chip properly supported in mainline would be the
best way to get SAE working. If you have hints on how to get involved in
that I'm curious, so far my wireless driver experience is limited to
"add USB ID for a new device with already supported chip". ;-)

> There's currently no way to force WPA3-only in iwd.  Either configure
> the AP to be WPA3 only, or have the AP enforce transition-disable bit.
> But this typically requires iwd to connect at least once with WPA3.  See
> 'TransitionDisable' and 'DisabledTransitionModes' in man 5 iwd.network

Good point, it should be a task for NetworkManager to make that clear to
the user (and possibly set those options, if the user wants to enforce
WPA3-only).

>> ---
>>   src/wiphy.c | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/wiphy.c b/src/wiphy.c
>> index 766df348..5530e9c6 100644
>> --- a/src/wiphy.c
>> +++ b/src/wiphy.c
>> @@ -248,6 +248,8 @@ static bool wiphy_can_connect_sae(struct wiphy
>> *wiphy)
>>            *
>>            * TODO: No support for CMD_EXTERNAL_AUTH yet.
>>            */
>> +        l_debug("Unsupported: %s needs CMD_EXTERNAL_AUTH for SAE",
>> +            wiphy->driver_str);
>
> I flipped this around and made this statement an l_warn to make it
> clearer that this is an iwd limitation.

Makes sense. :-)

Best regards,
Fiona


  reply	other threads:[~2024-01-10 11:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09  9:59 [PATCH] Log falling back from SAE to WPA2 Fiona Klute
2024-01-10  3:33 ` Denis Kenzior
2024-01-10 11:33   ` Fiona Klute [this message]
2024-01-10 16:51     ` Denis Kenzior
2024-01-10 13:12   ` Marcel Holtmann
2024-01-10 16:47     ` Denis Kenzior
2024-01-10 17:05       ` Marcel Holtmann
2024-01-10 17:10         ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=755dc5bf-1ac7-4eeb-ab16-8ded3aa6a25f@gmx.de \
    --to=fiona.klute@gmx.de \
    --cc=denkenz@gmail.com \
    --cc=iwd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox