From: Denis Kenzior <denkenz@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH] station: fix crash if affinities watch gets removed
Date: Tue, 10 Sep 2024 19:42:26 -0500 [thread overview]
Message-ID: <964b6536-cd88-4ed3-bb89-9f9f745e718f@gmail.com> (raw)
In-Reply-To: <20240910184750.126488-1-prestwoj@gmail.com>
Hi James,
On 9/10/24 1:47 PM, James Prestwood wrote:
> If the affinity watch is removed by setting an empty list the
> disconnect callback won't be called which was the only place
> the watch ID was cleared. This resulted in the next SetProperty call
> to think a watch existed, and attempt to compare the sender address
> which would be NULL.
>
> The watch ID should be cleared inside the destroy callback, not
> the disconnect callback.
> ---
> src/station.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2024-09-11 0:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 18:47 [PATCH] station: fix crash if affinities watch gets removed James Prestwood
2024-09-11 0:42 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=964b6536-cd88-4ed3-bb89-9f9f745e718f@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
--cc=prestwoj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox