From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH] network: add L_WARN for known network lookup failure
Date: Fri, 25 Oct 2019 13:19:47 -0500 [thread overview]
Message-ID: <a25b9c57-eae2-bf90-273e-ae71a1518720@gmail.com> (raw)
In-Reply-To: <20191025165321.19718-1-prestwoj@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 656 bytes --]
Hi James,
On 10/25/19 11:53 AM, James Prestwood wrote:
> When updating the network ranking there was a potential out of bounds
> array access. The condition was if known_network_offset returned a
> negative value, indicating the known network was not found. Since
> network->info is only set for known networks this should not ever
> happen as network->info is checked prior.
>
> Though this is likely impossible, knownnetworks is complex enough that
> its better to just be paranoid and put an L_WARN_ON to check the
> return.
> ---
> src/network.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2019-10-25 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 16:53 [PATCH] network: add L_WARN for known network lookup failure James Prestwood
2019-10-25 18:19 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a25b9c57-eae2-bf90-273e-ae71a1518720@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox