From: Denis Kenzior <denkenz at gmail.com>
To: iwd at lists.01.org
Subject: Re: [PATCH] station: Move netconfig_reset() to common path
Date: Wed, 29 Sep 2021 14:51:02 -0500 [thread overview]
Message-ID: <a85148df-d206-87d6-a3dd-9105ecc013ee@gmail.com> (raw)
In-Reply-To: 20210929164254.118503-1-andrew.zaborowski@intel.com
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
Hi Andrew,
On 9/29/21 11:42 AM, Andrew Zaborowski wrote:
> Move the netconfig_reset calls to inside
> station_reset_connection_state() instead of having each caller do
This is on purpose. There should be no need to call netconfig_reset if
netconfig_configure wasn't called in the first place.
> netconfig_reset() followed by station_reset_connection_state(). One of
> the callers was missing the netconfig_reset() and this was resulting in
> the "netconfig: Failed to start DHCPv4 client for interface %u" warning.
You need to figure out why calling netconfig_load_settings causes side-effects
and fix that instead.
> ---
> src/station.c | 12 +++---------
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
Regards,
-Denis
next reply other threads:[~2021-09-29 19:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 19:51 Denis Kenzior [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-29 23:14 [PATCH] station: Move netconfig_reset() to common path Andrew Zaborowski
2021-09-29 23:09 Denis Kenzior
2021-09-29 22:46 Denis Kenzior
2021-09-29 22:20 Andrew Zaborowski
2021-09-29 22:07 Denis Kenzior
2021-09-29 22:05 Andrew Zaborowski
2021-09-29 16:42 Andrew Zaborowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a85148df-d206-87d6-a3dd-9105ecc013ee@gmail.com \
--to=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox