From: James Prestwood <prestwoj@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: iwd@lists.linux.dev
Subject: Re: [PATCH 06/15] vendor_quirks: add two new vendor quirks
Date: Mon, 25 Aug 2025 07:32:17 -0700 [thread overview]
Message-ID: <ab281abb-6d8f-47e3-97c1-877d759dcabf@gmail.com> (raw)
In-Reply-To: <E8A1EBD8-1747-4961-A27B-CBFE37065866@holtmann.org>
Hi Marcel,
On 8/23/25 7:46 AM, Marcel Holtmann wrote:
> Hi James,
>
>> VENDOR_QUIRK_BAD_BSS_TM_CANDIDATE_LIST:
>> When a BSS requests a station roam it can optionally include a
>> list of BSS's that can be roamed to. IWD uses this list and only
>> scans on those frequencies. In some cases though the AP's list
>> contains very poor options and it would be better for IWD to
>> request a full neighbor report.
>>
>> VENDOR_QUIRK_REPLAY_COUNTER_MISMATCH:
>> On some Aruba APs there is a mismatch in the replay counters
>> between what is seen in scans versus authentications/associations.
>> This difference is not allowed in the spec, therefore IWD will
>> not connect. This quirk is intended to relax that check.
>> ---
>> src/vendor_quirks.c | 5 ++++-
>> src/vendor_quirks.h | 15 +++++++++++++++
>> 2 files changed, 19 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/vendor_quirks.c b/src/vendor_quirks.c
>> index ccfcb444..e005ba3b 100644
>> --- a/src/vendor_quirks.c
>> +++ b/src/vendor_quirks.c
>> @@ -34,7 +34,10 @@ static const struct {
>> uint8_t oui[3];
>> uint32_t quirks;
>> } quirk_db[] = {
>> - { }
>> + /* Cisco Meraki */
>> + { { 0x00, 0x18, 0x0a }, VENDOR_QUIRK_BAD_BSS_TM_CANDIDATE_LIST },
>> + /* Hewlitt Packard, owns Aruba */
>> + { { 0x00, 0x0b, 0x86 }, VENDOR_QUIRK_REPLAY_COUNTER_MISMATCH },
>> };
> are you sure the name is Hewlitt ;)
Whoops, will fix in v2
>
> Regards
>
> Marcel
>
next prev parent reply other threads:[~2025-08-25 14:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-22 19:51 [PATCH 01/15] wiphy: add driver quirk for the colocated scan flag James Prestwood
2025-08-22 19:51 ` [PATCH 02/15] wiphy: add comments around the driver quirks James Prestwood
2025-08-22 19:51 ` [PATCH 03/15] scan: check support before using colocated flag James Prestwood
2025-08-22 19:51 ` [PATCH 04/15] monitor: add Cisco Meraki as a printable vendor James Prestwood
2025-08-22 19:51 ` [PATCH 05/15] vendor_quirks: initial skeleton James Prestwood
2025-08-23 14:43 ` Marcel Holtmann
2025-08-25 14:31 ` James Prestwood
2025-08-26 14:56 ` Denis Kenzior
2025-08-22 19:51 ` [PATCH 06/15] vendor_quirks: add two new vendor quirks James Prestwood
2025-08-23 14:46 ` Marcel Holtmann
2025-08-25 14:32 ` James Prestwood [this message]
2025-08-22 19:51 ` [PATCH 07/15] handshake: pass object to handshake_util_ap_ie_matches James Prestwood
2025-08-22 19:51 ` [PATCH 08/15] handshake: add vendor quirks into handshake object James Prestwood
2025-08-22 19:51 ` [PATCH 09/15] scan: store vendor quirks in scan_bss James Prestwood
2025-08-22 19:51 ` [PATCH 10/15] station: set vendor quirks into handshake object James Prestwood
2025-08-22 19:51 ` [PATCH 11/15] handshake: use vendor quirk to disable check of replay counters James Prestwood
2025-08-22 19:51 ` [PATCH 12/15] station: get neighbor report on BSS TM request James Prestwood
2025-08-22 19:51 ` [PATCH 13/15] station: check vendor quirk for BSS TM request candidate list James Prestwood
2025-08-23 14:48 ` Marcel Holtmann
2025-08-25 14:37 ` James Prestwood
2025-08-22 19:51 ` [PATCH 14/15] station: clear roam_freqs on delayed roam James Prestwood
2025-08-26 15:00 ` Denis Kenzior
2025-08-22 19:51 ` [PATCH 15/15] auto-t: add AP roam test for bad neighbor reports/candidate lists James Prestwood
2025-08-26 14:47 ` [PATCH 01/15] wiphy: add driver quirk for the colocated scan flag Denis Kenzior
2025-08-26 15:24 ` James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab281abb-6d8f-47e3-97c1-877d759dcabf@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox