Re: [PATCH v2] agent: call back even if agent disconnects

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 941 bytes --]

Hi James,

On 4/9/21 11:37 AM, James Prestwood wrote:
> It was found that if the user cancels/disconnects the agent prior to
> entering credentials, IWD would get stuck and could no longer accept
> any connect calls with the error "Operation already in progress".
> For example exiting iwctl in the Password prompt would cause this:
> 
> iwctl
> $ station wlan0 connect myssid
> $ Password: <Ctrl-C>
> 
> This was due to the agent never calling the network callback in the
> case of an agent disconnect. Network would wait indefinitely for the
> credentials, and disallow any future connect attempts.
> 
> To fix this agent_finalize_pending can be called in agent_disconnect
> with a NULL reply which behaves the same as if there was an
> internal timeout and ultimately allows network to fail the connection
> ---
>   src/agent.c | 3 +++
>   1 file changed, 3 insertions(+)
> 

Applied, thanks.

Regards,
-Denis