From: Denis Kenzior <denkenz@gmail.com>
To: Sam James <sam@gentoo.org>, iwd@lists.linux.dev
Subject: Re: [PATCH] configure.ac: fix bashism
Date: Sun, 31 Dec 2023 20:35:52 -0600 [thread overview]
Message-ID: <aea77220-eeaf-4890-bb0c-315b5bd938a4@gmail.com> (raw)
In-Reply-To: <20231229003840.4152342-1-sam@gentoo.org>
Hi Sam,
On 12/28/23 18:38, Sam James wrote:
> configure scripts need to be runnable with a POSIX-compliant /bin/sh.
>
> On many (but not all!) systems, /bin/sh is provided by Bash, so errors
> like this aren't spotted. Notably Debian defaults to /bin/sh provided
> by dash which doesn't tolerate such bashisms as '+='.
>
> This retains compatibility with bash. Just copy the expanded append like
> we do on the line above.
>
> Fixes warnings like:
> ```
> ./configure: 13352: CFLAGS+= -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2: not found
> ```
> ---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2024-01-01 2:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 0:38 [PATCH] configure.ac: fix bashism Sam James
2024-01-01 2:35 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aea77220-eeaf-4890-bb0c-315b5bd938a4@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox