From: Denis Kenzior <denkenz at gmail.com>
To: iwd at lists.01.org
Subject: Re: [PATCH 1/3] auto-t: iwd.py: remove StationDebug out of Device init
Date: Tue, 04 Jan 2022 11:44:04 -0600 [thread overview]
Message-ID: <b9541a56-2e0e-0acf-4ed0-e84edac66751@gmail.com> (raw)
In-Reply-To: 20220104173736.93682-1-prestwoj@gmail.com
[-- Attachment #1: Type: text/plain, Size: 740 bytes --]
Hi James,
On 1/4/22 11:37, James Prestwood wrote:
> Since a Device class can represent multiple modes (AP, AdHoc, station)
> move StationDebug out of the init and only create this class when it
> is used (presumably only when the device is in station mode).
>
> The StationDebug class is now created in a property method consistent
> with 'station_if'. If Device is not in station mode it is automatically
> switched if the test tries any StationDebug methods.
>
> If the Device mode is changed from 'station' the StationDebug class
> instance is destroyed.
> ---
> autotests/util/iwd.py | 24 +++++++++++++++++-------
> 1 file changed, 17 insertions(+), 7 deletions(-)
>
All applied, thanks.
Regards,
-Denis
next reply other threads:[~2022-01-04 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 17:44 Denis Kenzior [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-04 17:37 [PATCH 1/3] auto-t: iwd.py: remove StationDebug out of Device init James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9541a56-2e0e-0acf-4ed0-e84edac66751@gmail.com \
--to=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox