From: Denis Kenzior <denkenz@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH 7/7] netdev: Simplify FILS handling in netdev_connect_common
Date: Mon, 5 Aug 2024 09:34:03 -0500 [thread overview]
Message-ID: <bb6dedb8-3baf-4d3b-9109-d193e47b09e3@gmail.com> (raw)
In-Reply-To: <4bb34106-49e9-45f1-a3d2-cab6329f2029@gmail.com>
Hi James,
>
> Mostly just an observation, but the switch block is pretty much just checks for
> SAE now, and the default build_cmd_connect case. It may look nicer to just have
> if/else if's for:
>
> IE_AKM_IS_FILS()
> IE_AKM_IS_OWE()
> IE_AKM_IS_SAE()
Totally agreed. I have taken out the switch in my pending patchset, but wanted
to get the easy stuff out of the way first :)
Reminds me we should add IE_AKM_IS_PSK() as well.
Regards,
-Denis
next prev parent reply other threads:[~2024-08-05 14:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 14:07 [PATCH 1/7] monitor: Decode RMNet Mux Identifier Denis Kenzior
2024-08-05 14:07 ` [PATCH 2/7] monitor: Mask flags from attribute identifier Denis Kenzior
2024-08-05 14:07 ` [PATCH 3/7] wiphy: Fix use of wiphy_has_feature Denis Kenzior
2024-08-05 14:07 ` [PATCH 4/7] ie: Add IE_AKM_IS_OWE Denis Kenzior
2024-08-05 14:07 ` [PATCH 5/7] netdev: Create owe_sm for fullmac connections Denis Kenzior
2024-08-05 14:07 ` [PATCH 6/7] fils: Ensure capability checks are consistent Denis Kenzior
2024-08-05 14:07 ` [PATCH 7/7] netdev: Simplify FILS handling in netdev_connect_common Denis Kenzior
2024-08-05 14:21 ` James Prestwood
2024-08-05 14:34 ` Denis Kenzior [this message]
2024-08-05 14:21 ` [PATCH 1/7] monitor: Decode RMNet Mux Identifier James Prestwood
2024-08-06 14:33 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb6dedb8-3baf-4d3b-9109-d193e47b09e3@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
--cc=prestwoj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox