From: Denis Kenzior <denkenz at gmail.com>
To: iwd at lists.01.org
Subject: Re: [PATCH 1/3] hwsim: check if radio name was already set
Date: Fri, 18 Feb 2022 14:45:29 -0600 [thread overview]
Message-ID: <bcfb68b0-d98b-d819-e9ca-ffe8b7779703@gmail.com> (raw)
In-Reply-To: 20220218195506.2145602-1-prestwoj@gmail.com
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
On 2/18/22 13:55, James Prestwood wrote:
> This was caught by static analysis and shouldn't ever happen.
> ---
> tools/hwsim.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/hwsim.c b/tools/hwsim.c
> index 3ff3faab..8c076f51 100644
> --- a/tools/hwsim.c
> +++ b/tools/hwsim.c
> @@ -639,6 +639,9 @@ static void get_radio_callback(struct l_genl_msg *msg, void *user_data)
> break;
>
> case HWSIM_ATTR_RADIO_NAME:
> + if (name)
> + return;
> +
I changed this to break instead of return.
> name = l_strndup(data, len);
> break;
> }
>
Applied, thanks.
Regards,
-Denis
next reply other threads:[~2022-02-18 20:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 20:45 Denis Kenzior [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-02-18 19:55 [PATCH 1/3] hwsim: check if radio name was already set James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcfb68b0-d98b-d819-e9ca-ffe8b7779703@gmail.com \
--to=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox