Re: [PATCH] tools: delay hwsim sending frame

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 935 bytes --]

Hi James,

On 5/4/20 3:16 PM, James Prestwood wrote:
> Using mac80211_hwsim can sometimes result in out of order messages
> coming from the kernel. Since mac80211_hwsim immediately sends out
> frames and the kernel keeps command responses in a separate queue,
> bad scheduling can result in these messages being out of order.
> In some cases we receive Auth/Assoc frames before the response to
> our original CMD_CONNECT. This causes autotests to fail randomly,
> some more often than others.
> 
> To fix this we can introduce a small delay into hwsim. Just a 1ms
> delay makes the random failures disappear in the tests. This delay
> is also makes hwsim more realistic since actual hardware will always
> introduce some kind of delay when sending or receiving frames.
> ---
>   tools/hwsim.c | 21 +++++++++++++++++----
>   1 file changed, 17 insertions(+), 4 deletions(-)
> 

Applied, thanks.

Regards,
-Denis