Re: [PATCH 3/4] station: set handshake offload if supported

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1017 bytes --]

Hi James,

On 3/3/21 11:47 AM, James Prestwood wrote:
> When setting up the handshake check if wiphy supports handshake
> offload for PSK networks (not including SAE, for now).
> ---
>   src/station.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/src/station.c b/src/station.c
> index 6496be10..93701e7f 100644
> --- a/src/station.c
> +++ b/src/station.c
> @@ -986,6 +986,8 @@ static struct handshake_state *station_handshake_setup(struct station *station,
>   				goto no_psk;
>   
>   			handshake_state_set_pmk(hs, psk, 32);
> +
> +			hs->offload_psk = wiphy_can_offload(wiphy, bss);

I actually wonder whether we need to put some of the logic from 
wiphy_can_offload into wiphy_select_akm instead?  Maybe the offload bit can be 
an extra out parameter?

I suspect we need to implement the logic for offloaded SAE to really know what 
will look best.

>   		}
>   	} else if (security == SECURITY_8021X)
>   		handshake_state_set_8021x_config(hs,
> 

Regards,
-Denis