From: Denis Kenzior <denkenz@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH v2] netdev: allow empty TX/RX bitrate attributes
Date: Fri, 20 Sep 2024 10:27:27 -0500 [thread overview]
Message-ID: <c3863d99-9e7c-4232-8d5d-39034b8ab5ae@gmail.com> (raw)
In-Reply-To: <20240920135536.203657-1-prestwoj@gmail.com>
Hi James,
On 9/20/24 8:55 AM, James Prestwood wrote:
> The TX or RX bitrate attributes can contain zero nested attributes.
> This causes netdev_parse_bitrate() to fail, but this shouldn't then
> cause the overall parsing to fail (we just don't have those values).
>
> Fix this by continuing to parse attributes if either the TX/RX
> bitrates fail to parse.
> ---
> src/netdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> v2:
> * Retain the other "return false" lines as these do indicate some
> kind of kernel bug if the lengths don't match up to expected.
>
Applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2024-09-20 15:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 13:55 [PATCH v2] netdev: allow empty TX/RX bitrate attributes James Prestwood
2024-09-20 15:27 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3863d99-9e7c-4232-8d5d-39034b8ab5ae@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
--cc=prestwoj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox