From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH] frame-xchg: fix incorrect length check
Date: Mon, 22 Jun 2020 10:30:32 -0500 [thread overview]
Message-ID: <cb35fbd9-cfe2-edb6-2e6b-2d2f50d9fb3e@gmail.com> (raw)
In-Reply-To: <20200622152516.22006-1-prestwoj@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
Hi James,
On 6/22/20 10:25 AM, James Prestwood wrote:
> frame_xchg_startv was using sizeof(mmpdu) to check the minimum length
> for a frame. Instead mmpdu_header_len should be used since this checks
> fc.order and returns either 24 or 28 bytes, not 28 bytes always.
>
> This change adds the requirement that the first iovec in the array
> must contain at least the first 2 bytes (mmpdu_fc) of the header.
> This really shouldn't be a problem since all current users of
> frame-xchg put the entire header (or entire frame) into the first
> iovec in the array.
> ---
> src/frame-xchg.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
Applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2020-06-22 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 15:25 [PATCH] frame-xchg: fix incorrect length check James Prestwood
2020-06-22 15:30 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cb35fbd9-cfe2-edb6-2e6b-2d2f50d9fb3e@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox