From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH] eapol: prevent key reinstallation on retransmitted Msg4/4
Date: Wed, 12 Aug 2020 09:55:22 -0500 [thread overview]
Message-ID: <cbae44c5-9f16-7acb-96ab-cedd46dcecd4@gmail.com> (raw)
In-Reply-To: <20200812111721.302407-1-Mathy.Vanhoef@kuleuven.be>
[-- Attachment #1: Type: text/plain, Size: 919 bytes --]
Hi Mathy,
On 8/12/20 6:17 AM, Mathy Vanhoef wrote:
> Currently an adversary can retransmit EAPOL Msg4/4 to make the AP
> reinstall the PTK. Against older Linux kernels this can subsequently
> be used to decrypt, replay, and possibly decrypt frames. See the
> KRACK attacks research at krackattacks.com for attack scenarios.
> In this case no machine-in-the-middle position is needed to trigger
> the key reinstallation.
>
> Fix this by using the ptk_complete boolean to track when the 4-way
> handshake has completed (similar to its usage for clients). When
> receiving a retransmitted Msg4/4 accept this frame but do not reinstall
> the PTK.
>
> Credits to Chris M. Stone, Sam Thomas, and Tom Chothia of Birmingham
> University to help discover this issue.
> ---
> src/eapol.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
Applied, thanks.
Regards,
-Denis
prev parent reply other threads:[~2020-08-12 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 11:17 [PATCH] eapol: prevent key reinstallation on retransmitted Msg4/4 Mathy Vanhoef
2020-08-12 14:55 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbae44c5-9f16-7acb-96ab-cedd46dcecd4@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox